Skip to content

Conversation

@etanxing
Copy link
Contributor

@etanxing etanxing commented Sep 19, 2023

✌️

/cc @zendesk/vegemite

Description

Trigger the deployment by matching the branch name instead of the tags.

https://github.com/zendesk/zendesk_apps_tools/settings/environments/585835778/edit
image

Tasks

  • Include comments/inline docs where appropriate
  • Write tests
  • Update changelog here

References

Risks

  • [low] GHA deployment update only

@etanxing etanxing marked this pull request as ready for review September 19, 2023 00:45
@etanxing etanxing requested a review from a team September 19, 2023 00:46
Shengming-Yan
Shengming-Yan previously approved these changes Oct 2, 2023
@Shengming-Yan Shengming-Yan dismissed their stale review October 2, 2023 05:09

Actually as check the discussion history: https://zendesk.slack.com/archives/CV1GMGC0H/p1692929856167359. probably we don't want any branch rule to trigger deployment.

@Shengming-Yan
Copy link

Has successfully triggered to published ruby gem: https://github.com/zendesk/zendesk_apps_tools/actions/runs/6181074791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants