-
-
Notifications
You must be signed in to change notification settings - Fork 132
feat(orm): add result plugin extension point #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
genu
wants to merge
19
commits into
zenstackhq:dev
Choose a base branch
from
genu:genu/discuss-attachment
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,606
−88
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5d83b85
feat(orm): add result plugin extension point for computed query fields
genu e9bcc60
fix(orm): handle omitted needs dependencies for ext result fields
genu ce8e984
fix(orm): address review feedback for ext result plugin
genu 22085eb
fix(tests): use type assertions for nested relation ext result tests
genu 7ddf9b5
fix(tests): skip createManyAndReturn test on MySQL
genu b5ada0f
feat(orm): thread ExtResult through nested relation types and add res…
genu 83ef2c5
refactor(orm): deduplicate ext result field types and helpers
genu e983add
chore(tests): add missing schema.zmodel for ext-result tests
genu 755b565
chore(tests): add missing generated files for ext-result tests
genu 6f8f3d6
perf(orm): hoist static Set and per-row Map in ext result helpers
genu b87739c
refactor(orm): simplify ext result field cleanup in applyExtResultToRow
genu 76305df
docs(orm): move JSDoc comment to SelectAwareExtResult where it belongs
genu 949a44b
feat(orm): tighten ExtResult type constraints and add validation tests
genu 06d0cf6
feat(orm): use lowercase model names in plugin result config
genu dd55e94
fix(orm): fix ExtResult type inference and Zod factory model name casing
genu ea7bf4c
fix(orm): validate ext result fields don't shadow real model fields
genu 8d2d39f
chore: update typo
genu 744c1f7
Merge branch 'zenstackhq:dev' into genu/discuss-attachment
genu 046e6c9
fix(orm): validate ext result `needs` keys against model schema
genu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.