Feat/Hashers: Implement sha256d :fixes #3#23
Feat/Hashers: Implement sha256d :fixes #3#23manoahLinks wants to merge 6 commits intozig-bitcoin:mainfrom
Conversation
|
|
||
| const result = engine.final(); | ||
|
|
||
| try std.testing.expect(std.mem.eql(u8, result, expected_hash)); |
There was a problem hiding this comment.
u can use here std.testing.expectEqualSlices
| @@ -0,0 +1,56 @@ | |||
| const std = @import("std"); | |||
| const Hash = std.crypto.sha256; | |||
There was a problem hiding this comment.
is it okay? std.crypto.sha256 is located in std.crypto.hash.sha2.Sha256
|
also u need import here sha256d, currently zig build test dont see ur test bitcoin-primitives/src/hashes/lib.zig Line 1 in 501399a |
| return HashEngine{ | ||
| .sha256_engine = Hash.Context.init(), | ||
| }; |
There was a problem hiding this comment.
| return HashEngine{ | |
| .sha256_engine = Hash.Context.init(), | |
| }; | |
| return .{ | |
| .sha256_engine = Hash.Context.init(), | |
| }; |
| const std = @import("std"); | ||
| const Hash = std.crypto.sha256; | ||
|
|
||
| pub const HashEngine = struct { |
There was a problem hiding this comment.
| pub const HashEngine = struct { | |
| pub const HashEngine = struct { | |
| const Self = @This(); |
There was a problem hiding this comment.
I will also suggest we rename this from HashEngine to Sha256d
| pub const HashEngine = struct { | ||
| sha256_engine: Hash.Context, | ||
|
|
||
| pub fn new() HashEngine { |
There was a problem hiding this comment.
| pub fn new() HashEngine { | |
| pub fn init() Self { |
| }; | ||
| } | ||
|
|
||
| pub fn input(self: *HashEngine, data: []const u8) void { |
There was a problem hiding this comment.
| pub fn input(self: *HashEngine, data: []const u8) void { | |
| pub fn input(self: *Self, data: []const u8) void { |
| self.sha256_engine.update(data); | ||
| } | ||
|
|
||
| pub fn n_bytes_hashed(self: *const HashEngine) usize { |
There was a problem hiding this comment.
| pub fn n_bytes_hashed(self: *const HashEngine) usize { | |
| pub fn n_bytes_hashed(self: *const Self) usize { |
| return self.sha256_engine.total_len; | ||
| } | ||
|
|
||
| pub fn final(self: *HashEngine) []u8 { |
There was a problem hiding this comment.
| pub fn final(self: *HashEngine) []u8 { | |
| pub fn final(self: *Self) []u8 { |
|
|
||
| const result = engine.final(); | ||
|
|
||
| try std.testing.expect(std.mem.eql(u8, result, expected_hash)); |
There was a problem hiding this comment.
expectEqualSlices is too
| return self.sha256_engine.total_len; | ||
| } | ||
|
|
||
| pub fn final(self: *HashEngine) []u8 { |
There was a problem hiding this comment.
Here why can't you return a [32]u8 as you know the size of the output at compile time no?
| sha2_engine.update(&sha1_result); | ||
|
|
||
| var sha2_result: [32]u8 = undefined; | ||
| sha2_engine.final(&sha2_result); |
There was a problem hiding this comment.
can we reuse here sha1_result, and not create a second buffer for output?
4 participants
No description provided.