Allow TLS scanners to downgrade to plaintext if handshake fails#680
Open
Seanstoppable wants to merge 3 commits intozmap:masterfrom
Open
Allow TLS scanners to downgrade to plaintext if handshake fails#680Seanstoppable wants to merge 3 commits intozmap:masterfrom
Seanstoppable wants to merge 3 commits intozmap:masterfrom
Conversation
Seanstoppable
force-pushed
the
ssmith/downgradetls
branch
from
4102cdd to
332166f
Compare
Especially for banner, when we have less of an expectation for WHAT might be listening, being able to try a TLS handshake, and downgrading to plaintext spares me from having to run a seperate scan or having to do a more complicated "multiple" module setup just to capture a large mix of errors
Seanstoppable
force-pushed
the
ssmith/downgradetls
branch
from
332166f to
db1a665
Compare
The existence of the tls_log should be sufficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially for banner, when we have less of an expectation for WHAT might be listening, being able to try a TLS handshake, and downgrading to plaintext spares me from having to run a seperate scan or having to do a more complicated "multiple" module setup just to capture a large mix of errors
Other protocols added for consistency