Skip to content

fix(release): update version retrieval and enhance asset upload for Windows compatibility #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombocoder merged 1 commit into from
Apr 30, 2026
Merged

fix(release): update version retrieval and enhance asset upload for Windows compatibility #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ jobs:

- name: Get version
id: get_version
run: echo "version=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT
shell: bash
run: echo "version=${GITHUB_REF#refs/tags/}" >> "$GITHUB_OUTPUT"

- name: Create release package (non-Windows)
if: matrix.platform != 'windows'
Expand Down Expand Up @@ -464,28 +465,19 @@ jobs:
hdiutil create -volname "BFC ${VERSION_NO_V}" -srcfolder dmg-contents -ov -format UDZO "${DMG_NAME}.dmg"

- name: Upload Release Assets
shell: bash
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VERSION: ${{ steps.get_version.outputs.version }}
run: |
echo "Current directory contents:"
ls -la

echo "Looking for package files..."
find . -name "*.tar.gz" -o -name "*.deb" -o -name "*.rpm" -o -name "*.dmg" | head -20

# Upload all package files to the existing release
for file in *.tar.gz *.deb *.rpm *.dmg; do
if [ -f "$file" ]; then
echo "Uploading $file to release ${VERSION}"
gh release upload "${VERSION}" "$file" --clobber
fi
find . -maxdepth 1 \( -name "*.tar.gz" -o -name "*.deb" -o -name "*.rpm" -o -name "*.dmg" -o -name "*.zip" \)

shopt -s nullglob
for file in *.tar.gz *.deb *.rpm *.dmg *.zip; do
echo "Uploading $file to release ${VERSION}"
gh release upload "${VERSION}" "$file" --clobber
done

# Also try to upload from current directory using find results
find . -maxdepth 1 \( -name "*.tar.gz" -o -name "*.deb" -o -name "*.rpm" -o -name "*.dmg" \) -exec bash -c '
for file; do
echo "Found and uploading: $file"
gh release upload "${{ steps.get_version.outputs.version }}" "$file" --clobber
done
' _ {} +
Loading