Skip to content

License finder#78

Merged
eguzki merged 5 commits intomasterfrom
license-finder
Dec 12, 2018
Merged

License finder#78
eguzki merged 5 commits intomasterfrom
license-finder

Conversation

@eguzki
Copy link
Member

@eguzki eguzki commented Dec 6, 2018

Two rake tasks added:

  • License finder check license_finder:check
  • License finder report license_finder:report

License finder check added on CI

License whitelist and approval list on /.dependency_decisions.yml

Note: Only CSV format report

@eguzki eguzki requested a review from unleashed December 6, 2018 17:20
:versions: []
:when: 2016-11-23 11:04:37.776089000 Z
- - :approve
- colored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also approved, but why and by who? What is the license?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency used by https://github.com/ddfreyne/cri

Does not have license info
https://rubygems.org/gems/colored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does have it in the source. https://github.com/defunkt/colored/blob/master/LICENSE
Would be good to link to the source and say what license it is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not in gemspec, so rubygems does not know and license_finder either.

I will add link to LICENSE file in why field

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defunkt/colored#10

almost 4 years old PR

end
end

desc 'Generate an CSV report for licenses'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you not need an XML report?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not AFAIK

XML report requires 3scale XML reporter which is not compatible with latest release (5.5) of license_finder. Thus, unless xml is required, is not included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML reported was merged upstream (pivotal/LicenseFinder#517) and should be avilable in the next release.

@eguzki eguzki merged commit 9749ba1 into master Dec 12, 2018
@eguzki eguzki deleted the license-finder branch December 12, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants