-
Notifications
You must be signed in to change notification settings - Fork 73
License finder #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License finder #78
Changes from all commits
ef4cb7a
19e92fc
4231b0b
6814162
ea89045
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| --- | ||
| - - :whitelist | ||
| - MIT | ||
| - :who: 3scale Engineering | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-08-16 09:25:15.635515271 Z | ||
| - - :whitelist | ||
| - Apache 2.0 | ||
| - :who: 3scale Engineering | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-08-16 09:26:31.814319646 Z | ||
| - - :whitelist | ||
| - MIT-LICENSE | ||
| - :who: 3scale Engineering | ||
| :why: It's the same as MIT | ||
| :versions: [] | ||
| :when: 2016-08-16 09:27:49.047135842 Z | ||
| - - :license | ||
| - rake | ||
| - MIT | ||
| - :who: 3scale Engineering | ||
| :why: Rake uses MIT but it's not automatically detected | ||
| :versions: [] | ||
| :when: 2016-08-18 15:16:38.712225384 Z | ||
| - - :whitelist | ||
| - BSD | ||
| - :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal) | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-11-23 11:02:51.564502000 Z | ||
| - - :whitelist | ||
| - New BSD | ||
| - :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal) | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-11-23 11:03:04.247155000 Z | ||
| - - :whitelist | ||
| - ruby | ||
| - :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal) | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-11-23 11:03:15.526798000 Z | ||
| - - :whitelist | ||
| - Simplified BSD | ||
| - :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal) | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-11-23 11:03:33.341497000 Z | ||
| - - :whitelist | ||
| - LGPLv2+ | ||
| - :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal) | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-11-23 11:04:13.584885000 Z | ||
| - - :whitelist | ||
| - 2-clause BSDL | ||
| - :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal) | ||
| :why: | ||
| :versions: [] | ||
| :when: 2016-11-23 11:04:37.776089000 Z | ||
| - - :approve | ||
| - colored | ||
| - :who: | ||
| :why: MIT License https://github.com/defunkt/colored/blob/master/LICENSE | ||
| :versions: [] | ||
| :when: 2018-12-06 16:05:25.674247558 Z | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,5 +4,6 @@ source 'https://rubygems.org' | |
| gemspec | ||
|
|
||
| group :development do | ||
| gem 'license_finder', '~> 5.5' | ||
| gem 'pry' | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,22 @@ rescue LoadError | |
| warn 'RSpec is not installed!' | ||
| end | ||
|
|
||
| namespace :license_finder do | ||
| DECISION_FILE = "#{File.dirname(__FILE__)}/.dependency_decisions.yml".freeze | ||
|
|
||
| desc 'Check license compliance of dependencies' | ||
| task :check do | ||
| STDOUT.puts "Checking license compliance\n" | ||
| unless system("license_finder --decisions-file=#{DECISION_FILE}") | ||
| STDERR.puts "\n*** License compliance test failed ***\n" | ||
| exit 1 | ||
| end | ||
| end | ||
|
|
||
| desc 'Generate an CSV report for licenses' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will you not need an XML report?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not AFAIK XML report requires 3scale XML reporter which is not compatible with latest release (5.5) of license_finder. Thus, unless xml is required, is not included.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The XML reported was merged upstream (pivotal/LicenseFinder#517) and should be avilable in the next release. |
||
| task :report do | ||
| system("license_finder report --decisions-file=#{DECISION_FILE} --format=csv") | ||
| end | ||
| end | ||
|
|
||
| task default: 'spec:all' | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also approved, but why and by who? What is the license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency used by https://github.com/ddfreyne/cri
Does not have license info
https://rubygems.org/gems/colored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does have it in the source. https://github.com/defunkt/colored/blob/master/LICENSE
Would be good to link to the source and say what license it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but not in gemspec, so rubygems does not know and license_finder either.
I will add link to LICENSE file in
whyfieldThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defunkt/colored#10
almost 4 years old PR