Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions .dependency_decisions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
---
- - :whitelist
- MIT
- :who: 3scale Engineering
:why:
:versions: []
:when: 2016-08-16 09:25:15.635515271 Z
- - :whitelist
- Apache 2.0
- :who: 3scale Engineering
:why:
:versions: []
:when: 2016-08-16 09:26:31.814319646 Z
- - :whitelist
- MIT-LICENSE
- :who: 3scale Engineering
:why: It's the same as MIT
:versions: []
:when: 2016-08-16 09:27:49.047135842 Z
- - :license
- rake
- MIT
- :who: 3scale Engineering
:why: Rake uses MIT but it's not automatically detected
:versions: []
:when: 2016-08-18 15:16:38.712225384 Z
- - :whitelist
- BSD
- :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal)
:why:
:versions: []
:when: 2016-11-23 11:02:51.564502000 Z
- - :whitelist
- New BSD
- :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal)
:why:
:versions: []
:when: 2016-11-23 11:03:04.247155000 Z
- - :whitelist
- ruby
- :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal)
:why:
:versions: []
:when: 2016-11-23 11:03:15.526798000 Z
- - :whitelist
- Simplified BSD
- :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal)
:why:
:versions: []
:when: 2016-11-23 11:03:33.341497000 Z
- - :whitelist
- LGPLv2+
- :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal)
:why:
:versions: []
:when: 2016-11-23 11:04:13.584885000 Z
- - :whitelist
- 2-clause BSDL
- :who: Jeff Kaufmann and Richard Fontana (Red Hat Legal)
:why:
:versions: []
:when: 2016-11-23 11:04:37.776089000 Z
- - :approve
- colored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also approved, but why and by who? What is the license?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency used by https://github.com/ddfreyne/cri

Does not have license info
https://rubygems.org/gems/colored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does have it in the source. https://github.com/defunkt/colored/blob/master/LICENSE
Would be good to link to the source and say what license it is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not in gemspec, so rubygems does not know and license_finder either.

I will add link to LICENSE file in why field

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defunkt/colored#10

almost 4 years old PR

- :who:
:why: MIT License https://github.com/defunkt/colored/blob/master/LICENSE
:versions: []
:when: 2018-12-06 16:05:25.674247558 Z
7 changes: 4 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ cache: bundler
before_install:
- gem install bundler -v 1.15.1
rvm:
- 2.5.1
- 2.4.1
- 2.3.1
- 2.5.3
- 2.4.5
- 2.3.8
script:
- bundle exec rake license_finder:check
- bundle exec rake spec:all
- bundle exec 3scale help
- bundle exec 3scale help copy
Expand Down
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ source 'https://rubygems.org'
gemspec

group :development do
gem 'license_finder', '~> 5.5'
gem 'pry'
end
18 changes: 18 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,22 @@ rescue LoadError
warn 'RSpec is not installed!'
end

namespace :license_finder do
DECISION_FILE = "#{File.dirname(__FILE__)}/.dependency_decisions.yml".freeze

desc 'Check license compliance of dependencies'
task :check do
STDOUT.puts "Checking license compliance\n"
unless system("license_finder --decisions-file=#{DECISION_FILE}")
STDERR.puts "\n*** License compliance test failed ***\n"
exit 1
end
end

desc 'Generate an CSV report for licenses'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you not need an XML report?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not AFAIK

XML report requires 3scale XML reporter which is not compatible with latest release (5.5) of license_finder. Thus, unless xml is required, is not included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML reported was merged upstream (pivotal/LicenseFinder#517) and should be avilable in the next release.

task :report do
system("license_finder report --decisions-file=#{DECISION_FILE} --format=csv")
end
end

task default: 'spec:all'