Skip to content

Entry with double #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Paget96 merged 1 commit into from
Jan 19, 2026
Merged

Entry with double #674

Paget96 merged 1 commit into from
Jan 19, 2026
+213 −81

Conversation

@hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Jan 18, 2026 •
edited
Loading

close #388

@hannesa2 hannesa2 marked this pull request as draft January 18, 2026 10:57
@hannesa2 hannesa2 mentioned this pull request Jan 18, 2026
Closed
hannesa2
hannesa2 commented Jan 18, 2026
View reviewed changes
chartLib/src/main/kotlin/info/appdev/charting/data/EntryDouble.kt
* Class representing one entry in the chart. Might contain multiple values.
* Might only contain a single value depending on the used constructor.
*/
open class EntryDouble : BaseEntry<Double>, Parcelable, Serializable {
Copy link
Collaborator Author

@hannesa2 hannesa2 Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Paget96 using a generic in in my opinion the way to go.
Then everyone can decide which kind of precision he wants to use.

The only thing is currently, it needs "just" to be done properly

@hannesa2 hannesa2 added the enhancement New feature or request label Jan 18, 2026
@hannesa2 hannesa2 marked this pull request as ready for review January 18, 2026 18:19
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 18, 2026

Making this fully generic is complex because:

  • The Canvas drawing APIs require Float values
  • We need to convert between generic N : Number and Float for drawing
  • Arithmetic operations don't work directly on generic Number types

@Paget96 Paget96 merged commit f05c0ec into master Jan 19, 2026
2 checks passed
@Paget96 Paget96 deleted the EntryDouble branch January 19, 2026 04:32
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 19, 2026

This one was not finished, currently you can't use EntryDouble instead of Entry in LineChart. I will revert the merge and open it again.
Merging it was not intended. I'm fast in merge, but only when it works properly

hannesa2 added a commit that referenced this pull request Jan 19, 2026
@hannesa2
Revert "Merge pull request #674 from AppDevNext/EntryDouble"
0aecddf 
This reverts commit f05c0ec, reversing
changes made to f20d4a8.
This was referenced Jan 19, 2026
Merged
Draft
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 19, 2026

I will make my non finished stuff as draft now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Paget96 Paget96 Paget96 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LineChart X axis needs Double.

3 participants

@hannesa2 @Paget96