feat: physics2d Cardinal integration tests#881
Closed
AnthonyWadham wants to merge 1 commit intoAnthony/fix-archtypefrom
Closed
feat: physics2d Cardinal integration tests#881AnthonyWadham wants to merge 1 commit intoAnthony/fix-archtypefrom
AnthonyWadham wants to merge 1 commit intoAnthony/fix-archtypefrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
d9f8d2d to
e2df156
Compare
a306990 to
2a9db46
Compare
e2df156 to
95b4e31
Compare
2a9db46 to
349a200
Compare
95b4e31 to
b78a11e
Compare
349a200 to
a46fb0f
Compare
b78a11e to
827ef2b
Compare
a46fb0f to
e015af6
Compare
df02eeb to
bfea11f
Compare
c66bed2 to
6bf8afb
Compare
bbec663 to
95f7a23
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
9426240 to
407ce21
Compare
95f7a23 to
0b4b860
Compare
82f0d7c to
b84c1ad
Compare
0b4b860 to
0f421d7
Compare
0f421d7 to
47e63d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Removes detailed comment from physics collider field and adds comprehensive Cardinal-driven integration tests for the physics2d plugin.
What changed?
GroupIndexfield inColliderShapestruct, keeping only the field declarationcardinal_integration_test.go) for the physics2d plugin that:ResetRuntime()to test synthetic event generationHow to test?
Run the new integration test:
go test ./pkg/plugin/physics2d/test/The test creates a Cardinal world, registers the physics plugin, runs 360+ ticks of simulation, and validates physics behavior including collision detection, query operations, and crash recovery scenarios.
Why make this change?
The comprehensive integration tests provide end-to-end validation of the physics2d plugin's integration with Cardinal, ensuring proper system event handling, query functionality, and crash recovery behavior that unit tests cannot cover. The tests verify the complete tick lifecycle (PreUpdate reconcile, Update step, PostUpdate) and validate that the plugin correctly handles ECS changes, entity lifecycle events, and runtime crashes with proper recovery.