Newsletter: enable modernized dashboard by default#49036
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
|
That tab shift issue is due to the use of AdminPage. The other modernized dashboard use the same component, so by standardizing it I can find a general fix now. Will work on it today. |
bce2208 to
bdb7341
Compare
Flip the defaults of the `rsm_jetpack_ui_modernization_newsletter` and `jetpack_wp_admin_subscriber_management_enabled` filters from false to true at every call site, releasing the modernized Newsletter dashboard and wp-admin subscriber management. Hosts can still opt out via `__return_false` listeners. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bdb7341 to
44f97c1
Compare

Closes #48530
Proposed changes
falsetotrueat every call site:rsm_jetpack_ui_modernization_newsletter— the canonical gate for the wp-build Newsletter dashboard. Now defaults on inNewsletter\Settings::is_modernized(), thewpcom/v2/subscribers/*REST route registration, thesubscriptionsmodule menu, and the jetpack-mu-wpcom admin menu (the legacy Calypso "Subscribers" submenu is retired).jetpack_wp_admin_subscriber_management_enabled— now defaults on in the Newsletter script data, thesubscriptionsmodule menu, and the Jetpack Redux state.add_filter( '<flag>', '__return_false' ).test_is_modernized_defaults_to_false→test_is_modernized_defaults_to_true.MODERNIZATION_FILTERconstants are separate flags and are intentionally untouched.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
GET /wpcom/v2/subscribers/listis registered (returns a401/data response, notrest_no_route).add_filter( 'rsm_jetpack_ui_modernization_newsletter', '__return_false' );(and/orjetpack_wp_admin_subscriber_management_enabled) via a snippet and confirm the legacy behavior returns — proving the opt-out still works.