Skip to content

Connection: dynamic logo and tooltip in users list#49093

Open
bindlegirl wants to merge 6 commits into
trunkfrom
update/users-list-dynamic-logo
Open

Connection: dynamic logo and tooltip in users list#49093
bindlegirl wants to merge 6 commits into
trunkfrom
update/users-list-dynamic-logo

Conversation

@bindlegirl
Copy link
Copy Markdown
Contributor

@bindlegirl bindlegirl commented May 22, 2026 •
edited
Loading

Proposed changes

  • Replace the hardcoded jetpack-icon.svg in the users list "Connected" status with the dynamic connector logo (Jetpack_Connector::get_connector_logo_url()), which adapts based on connected plugin families (Woo, A4A, default).
  • Make the column header tooltip dynamic too — it now mentions WooCommerce and/or Automattic for Agencies when those plugins are using the connection.
  • Move the SSO warning icon before the "Send invite" link text and align it with the connected logo layout.
Screenshot 2026-05-22 at 14 42 25 Screenshot 2026-05-22 at 14 39 23 Screenshot 2026-05-22 at 13 41 34 Screenshot 2026-05-22 at 13 40 33

Builds on #48951.

Other information

  • Generate changelog entries for this PR (using AI).

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. Go to Users screen.
  2. Verify the connected logo adapts based on which plugin families are active (Jetpack only, Jetpack + Woo, etc.).
  3. Hover the column header tooltip — it should mention the relevant plugins.
  4. For non-connected users with SSO enabled, verify the warning icon now appears before the "Send invite" link text.

Made with Cursor

bindlegirl and others added 3 commits May 22, 2026 12:32
@bindlegirl @cursoragent
Connection: use dynamic connector logo in users list and reorder invi…
3a748c3 
…te icon

Replace the hardcoded jetpack-icon.svg in the users list "Connected"
status with the dynamic logo from Jetpack_Connector::get_connector_logo_url(),
which adapts based on connected plugin families (Woo, A4A, default).

Also move the SSO warning icon before the "Send invite" link text and
align it with the connected logo layout using inline-flex.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bindlegirl @cursoragent
Connection: make users list column tooltip dynamic based on connected…
9162821 
… plugins

Adapt the tooltip text to mention WooCommerce and/or Automattic for
Agencies when those plugin families are using the connection, matching
the dynamic logo behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bindlegirl @cursoragent
Add changelog entry for connection package
5f4150c 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bindlegirl bindlegirl added the [Status] Needs Review This PR is ready for review. label May 22, 2026
@bindlegirl bindlegirl self-assigned this May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/users-list-dynamic-logo branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/users-list-dynamic-logo

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/users-list-dynamic-logo

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@bindlegirl @cursoragent
Connection: extract shared get_connected_plugin_families() helper
a126ab4 
Avoid duplicating the plugin family detection logic between
Jetpack_Connector and Users_Connection_Admin by extracting it
into a public static method on Jetpack_Connector.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 22, 2026 •
edited
Loading

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/packages/connection/src/class-users-connection-admin.php 1/114 (0.88%) -0.18% 19 💔
projects/packages/connection/src/sso/class-user-admin.php 0/823 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/connection/src/connectors/class-jetpack-connector.php 148/195 (75.90%) 0.63% 0 💚

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

bindlegirl and others added 2 commits May 22, 2026 13:42
@bindlegirl @cursoragent
Connection: use fixed-width icon slot for consistent logo/icon alignment
e9ca823 
Use a 31px-wide container that centers both the connector logo and the
SSO warning dashicon. Logos scale to fill the slot width (two-logo combo
renders at ~31x18px, square multi-logo combos at ~31x31px). Text starts
at the same horizontal position across all rows.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bindlegirl @cursoragent
Connection: add tests for get_connected_plugin_families() helper
11f88b2 
Test all variants (default, jetpack-only, woo, a4a, both) and simplify
the existing call_get_connector_logo_url() helper now that the method
is public.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bindlegirl bindlegirl requested review from keoshi and simison May 22, 2026 13:44
@bindlegirl bindlegirl marked this pull request as ready for review May 22, 2026 13:44
@bindlegirl bindlegirl requested a review from a team as a code owner May 22, 2026 13:44
@CGastrell CGastrell mentioned this pull request May 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simison simison Awaiting requested review from simison

@keoshi keoshi Awaiting requested review from keoshi

Assignees

@bindlegirl bindlegirl

Labels

[Feature] SSO [Package] Connection [Status] In Progress [Status] Needs Review This PR is ready for review. [Tests] Includes Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bindlegirl