Skip to content

classic-theme-helper: Add notice that Custom Content Types are primarily for classic themes#49104

Draft
agent-sandbox-automattic[bot] wants to merge 1 commit into
trunkfrom
ai/agent/dotcom-17145-1779470736
Draft

classic-theme-helper: Add notice that Custom Content Types are primarily for classic themes#49104
agent-sandbox-automattic[bot] wants to merge 1 commit into
trunkfrom
ai/agent/dotcom-17145-1779470736

Conversation

@agent-sandbox-automattic
Copy link
Copy Markdown
Contributor

What

Adds an informational notice in Settings → Writing under the "Your Custom Content Types" section heading, explaining that Portfolio and Testimonials features are primarily designed for classic themes. The notice includes a link to the Jetpack support guide at https://jetpack.com/support/custom-content-types/.

Why

Users on block themes (e.g. Videomaker) were disabling Portfolio without realizing that doing so could also remove the toggle from Settings → Writing, making it appear the feature was gone entirely. This simple static notice aligns with the stakeholder's request to add descriptive text under the section heading clarifying the classic-theme nature of these features.

How

Modified jetpack_cpt_section_callback() in projects/packages/classic-theme-helper/src/custom-content-types.php:

  • The notice is always visible (no conditional on theme type) — it's a general informational message
  • Uses Redirect::get_url( 'jetpack-support-custom-content-types' ) when the Redirect class is available, with a direct URL fallback
  • Properly escaped with wp_kses(), esc_url(), and __() with the jetpack-classic-theme-helper text domain
  • No JavaScript, no FSE-detection logic — keeps it simple as requested

Test plan

  • Visit Settings → Writing on a WordPress site with Jetpack's classic-theme-helper active
  • Confirm the notice "These features are primarily designed for classic themes. Learn more." appears under the "Your Custom Content Types" heading
  • Confirm the "Learn more" link points to the custom content types support page
  • Verify the notice appears on both classic and block themes

🤖 Generated with Claude Code


Linear: DOTCOM-17145

This PR was auto-generated by AI Coder. Please review carefully before merging.

…ily for classic themes

Adds an informational notice in Settings > Writing under "Your Custom
Content Types" indicating that Portfolio and Testimonials features are
primarily designed for classic themes, with a link to the support guide
at jetpack.com/support/custom-content-types/.

This addresses the case where users on block themes disable Portfolio
(or Testimonials) without realizing the toggle may disappear from the
Settings > Writing screen.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the ai/agent/dotcom-17145-1779470736 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack ai/agent/dotcom-17145-1779470736
bin/jetpack-downloader test jetpack-mu-wpcom-plugin ai/agent/dotcom-17145-1779470736

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 22, 2026
@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/classic-theme-helper/src/custom-content-types.php 0/109 (0.00%) 0.00% 16 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Theme Tools [Package] Classic Theme Helper [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant