[KeyVault] Fix #33367 az keyvault show-deleted: Fix keyvault show-deleted missing-arg hint and add regression test#33374
Open
flcdrg wants to merge 1 commit into
Open
Conversation
Fix keyvault show-deleted missing-arg hint and add regression test Agent-Logs-Url: https://github.com/flcdrg/azure-cli/sessions/3235ca65-38e7-45ad-95d2-b1515574eb7b Co-authored-by: flcdrg <384747+flcdrg@users.noreply.github.com>
flcdrg
requested review from
isra-fel,
notyashhh,
teresaritorto and
xuming-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| acr replication create | cmd acr replication create added parameter region_endpoint_enabled |
||
| acr replication update | cmd acr replication update added parameter region_endpoint_enabled |
⚠️ postgresql
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| postgres flexible-server create | cmd postgres flexible-server create added parameter subnet_address_prefix |
||
| postgres flexible-server create | cmd postgres flexible-server create added parameter vnet_address_prefix |
||
| postgres flexible-server create | cmd postgres flexible-server create added property deprecate_info_target |
||
| postgres flexible-server geo-restore | cmd postgres flexible-server geo-restore added parameter subnet_address_prefix |
||
| postgres flexible-server geo-restore | cmd postgres flexible-server geo-restore added parameter vnet_address_prefix |
||
| postgres flexible-server geo-restore | cmd postgres flexible-server geo-restore added property deprecate_info_target |
||
| postgres flexible-server replica create | cmd postgres flexible-server replica create added parameter subnet_address_prefix |
||
| postgres flexible-server replica create | cmd postgres flexible-server replica create added parameter vnet_address_prefix |
||
| postgres flexible-server replica create | cmd postgres flexible-server replica create added property deprecate_info_target |
||
| postgres flexible-server restore | cmd postgres flexible-server restore added parameter subnet_address_prefix |
||
| postgres flexible-server restore | cmd postgres flexible-server restore added parameter vnet_address_prefix |
||
| postgres flexible-server restore | cmd postgres flexible-server restore added property deprecate_info_target |
||
| postgres flexible-server revive-dropped | cmd postgres flexible-server revive-dropped added parameter subnet_address_prefix |
||
| postgres flexible-server revive-dropped | cmd postgres flexible-server revive-dropped added parameter vnet_address_prefix |
||
| postgres flexible-server revive-dropped | cmd postgres flexible-server revive-dropped added property deprecate_info_target |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @flcdrg! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
KeyVault
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the missing-argument error text for deleted Key Vault/HSM validation so az keyvault show-deleted points users to the actual --name option.
Changes:
- Updates the validator error message from
--vault-nameto--name. - Adds a regression unit test for the missing-name validation path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/keyvault/_validators.py |
Corrects the missing-argument hint for deleted vault/HSM commands. |
src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/test_keyvault_validators.py |
Adds unit coverage for the corrected validator message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az keyvault show-deleted
Description
Correct the parameter name returned in error message
Testing Guide
az keyvault show-deleted --query ""Should now return error message mentioning
--nameinstead of--vault-nameThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
Agent-Logs-Url: https://github.com/flcdrg/azure-cli/sessions/3235ca65-38e7-45ad-95d2-b1515574eb7b
Co-authored-by: flcdrg 384747+flcdrg@users.noreply.github.com