Version 1.23.0 by tastybento · Pull Request #484 · BentoBoxWorld/AOneBlock

tastybento · 2026-04-05T23:59:55Z

Summary

Bump version to 1.23.0

Changes since 1.22.0

HEX / MiniMessage color support in the action bar (461 no support for hex colors in the /ob actionbar command #469)
Nexo custom block support (Add Nexo custom block support #474)
Russian locale updated to MiniMessage format (Update Russian locale to MiniMessage format with grammar corrections #479)
Fix ONEBLOCK_ACTIONBAR translation indentation (Fix ONEBLOCK_ACTIONBAR translation not appearing in settings #480)
Fix wrong locale keys in AdminSanityCheck (Fix wrong locale keys in AdminSanityCheck #481)
Fix action bar color codes stripped by getTranslationNoColor (Fix action bar color codes stripped by getTranslationNoColor #482)
BentoBox API upgraded to 3.10.0
Code quality improvements: reduced complexity in BlockListener and MakeSpace, expanded test coverage

Test plan

Full test suite passes (mvn test)
Verify version is 1.23.0 in built jar

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…vent handling

…d modularity

…aracters

… classes

…kPhase

Copilot

Pull request overview

Release/version bump to 1.23.0, updating addon metadata and refining UI/logging/test behavior to support recent feature work (action bar color support, Nexo integration, locale updates, and code quality improvements).

Changes:

Bump project version to 1.23.0 and update addon API metadata.
Refactor PhasesPanel and OneBlocksManager#getProbs() to reduce complexity and improve maintainability.
Update tests to align with Adventure Title usage and add additional safety assertions.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/test/java/world/bentobox/aoneblock/TestWorldSettings.java	Add explicit no-op comment in stubbed method.
src/test/java/world/bentobox/aoneblock/listeners/StartSafetyListenerTest.java	Add explicit no-op comments in stubbed methods.
src/test/java/world/bentobox/aoneblock/listeners/CheckPhaseTest.java	Update assertions to verify Adventure `Title` usage.
src/test/java/world/bentobox/aoneblock/listeners/BlockListenerTest2.java	Tighten tests with `assertDoesNotThrow`; minor visibility tweak.
src/main/resources/addon.yml	Update declared BentoBox `api-version`.
src/main/java/world/bentobox/aoneblock/panels/PhasesPanel.java	Refactor phase button creation into helper methods; simplify formatting logic.
src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java	Refactor probability logging into smaller helper methods.
src/main/java/world/bentobox/aoneblock/listeners/CheckPhase.java	Switch to Adventure titles and component-based requirement messages.
pom.xml	Bump build version to 1.23.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/java/world/bentobox/aoneblock/listeners/CheckPhase.java

src/main/resources/addon.yml

Copilot · 2026-04-06T05:04:34Z

@tastybento I've opened a new pull request, #485, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-04-06T05:05:25Z

@tastybento I've opened a new pull request, #486, to work on those changes. Once the pull request is ready, I'll request review from you.

…custom translate() with LegacyComponentSerializer Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/3ae91a34-99b8-44ae-bdce-bc776883a2f9 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

…port Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/8ff2ce9e-417f-45e9-92d3-d6649871f7c7 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Bump BentoBox dependency to 3.13.0 for MiniMessage support

… LegacyComponentSerializer) Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/e8854ea2-7b56-497a-ac76-533846ce7957 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

…t.sendMessage() Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/b792d2e9-3944-46fa-9f8e-2339f94967e8 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove custom translate() helper from CheckPhase — let BentoBox handle MiniMessage natively

sonarqubecloud · 2026-04-07T01:59:15Z

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T02:07:43Z

src/main/java/world/bentobox/aoneblock/panels/PhasesPanel.java

+                "[starting-block]", biomeText,
+                BIOME, blockText,


In the default description branch, the placeholder replacements for [starting-block] and [biome] look swapped: "[starting-block]" is being replaced with biomeText and [biome] is being replaced with blockText. This will render the biome line where the starting-block line should be (and vice versa) in the phases GUI. Swap these arguments so [starting-block] maps to blockText and [biome] maps to biomeText (or to the translated biome line, depending on intended formatting).

Suggested change

"[starting-block]", biomeText,

BIOME, blockText,

"[starting-block]", blockText,

BIOME, biomeText,

Copilot · 2026-04-07T02:07:43Z

pom.xml

        <mockito.version>5.11.0</mockito.version>
        <mock-bukkit.version>v1.21-SNAPSHOT</mock-bukkit.version>
        <!-- More visible way how to change dependency versions -->
-        <bentobox.version>3.10.0</bentobox.version>
+        <bentobox.version>3.13.0</bentobox.version>
        <items-adder.version>4.0.10</items-adder.version>
        <nexo.version>1.8.0</nexo.version>


PR description says "BentoBox API upgraded to 3.10.0", but this change bumps the build dependency to 3.13.0. Please update the PR description (or adjust the version here) so the stated API upgrade matches what is actually being shipped.

Copilot · 2026-04-07T02:07:43Z

src/test/java/world/bentobox/aoneblock/listeners/CheckPhaseTest.java

        // Verify phase name change
        assertEquals("Next Phase", is.getPhaseName());
        // Verify title shown
-        verify(mockPlayer).sendTitle("Next Phase", null, -1, -1, -1);
+        verify(mockPlayer).showTitle(any(Title.class));



This verification only checks that some Title was shown, not that it contains the expected phase name. Consider capturing the Title argument and asserting the title component renders to "Next Phase" (and that subtitle/timings are as expected) so the test guards the behavior of setNewPhase() more effectively.

Copilot · 2026-04-07T02:07:44Z

src/test/java/world/bentobox/aoneblock/listeners/CheckPhaseTest.java

        // Verify phase name change
        assertEquals("Next Phase", is.getPhaseName());
        // Verify title shown
-        verify(mockPlayer).sendTitle("Next Phase", null, -1, -1, -1);
+        verify(mockPlayer).showTitle(any(Title.class));



Here the test verifies showTitle(any(Title.class)) but does not assert that the Title contains the expected phase name. Capturing the Title and checking its contents would prevent regressions where the wrong text is shown (or where the call is made with an empty title).

Copilot · 2026-04-07T02:07:44Z

src/test/java/world/bentobox/aoneblock/listeners/CheckPhaseTest.java

        // Verify phase name change
        assertEquals("Next Phase", is.getPhaseName());
        // Verify title shown
-        verify(mockPlayer).sendTitle("Next Phase", null, -1, -1, -1);
+        verify(mockPlayer).showTitle(any(Title.class));



This assertion only checks that showTitle(...) was invoked, but not what was shown. To ensure setNewPhase() displays the correct phase title when player is null (owner fallback), capture the Title argument and assert its title text matches "Next Phase".

Copilot · 2026-04-07T02:07:44Z

src/test/java/world/bentobox/aoneblock/listeners/CheckPhaseTest.java

        // Verify phase name change
        assertEquals("Next Phase", is.getPhaseName());
        // Verify title shown
-        verify(mockPlayer).sendTitle("Next Phase", null, -1, -1, -1);
+        verify(mockPlayer).showTitle(any(Title.class));



Same as the other setNewPhase tests: showTitle(any(Title.class)) doesn't verify the shown title content. Capturing and asserting the Title argument (e.g., that it renders the new phase name) will make this test actually validate the behavior.

tastybento and others added 8 commits April 5, 2026 16:59

Version 1.23.0

0c55d53

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Update BlockListenerTest2 to assert no exceptions are thrown during e…

c824533

…vent handling

Refactor OneBlocksManager and PhasesPanel for improved readability an…

955381b

…d modularity

Fix description formatting in PhasesPanel to correctly handle pipe ch…

f0d8bc7

…aracters

Add no-op implementations for setDifficulty and setResetEpoch in test…

b1e6985

… classes

Update API version to 3.14.0 in addon.yml

2b0ad28

Implement translation key handling using Adventure Components in Chec…

8c007f6

…kPhase

Downgrade API version to 3.13.0 in addon.yml

f6f120c

tastybento requested a review from Copilot April 6, 2026 04:54

Copilot started reviewing on behalf of tastybento April 6, 2026 04:54 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

src/main/java/world/bentobox/aoneblock/listeners/CheckPhase.java Outdated Show resolved Hide resolved

src/main/resources/addon.yml Show resolved Hide resolved

Initial plan

59fc0a2

Copilot AI mentioned this pull request Apr 6, 2026

Remove custom translate() helper from CheckPhase — let BentoBox handle MiniMessage natively #485

Merged

3 tasks

Initial plan

ef97465

Copilot AI mentioned this pull request Apr 6, 2026

Bump BentoBox dependency to 3.13.0 for MiniMessage support #486

Merged

Copilot AI and others added 8 commits April 6, 2026 05:08

chore: update BentoBox Maven dependency to 3.13.0 for MiniMessage sup…

7f19977

…port Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/8ff2ce9e-417f-45e9-92d3-d6649871f7c7 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Merge pull request #486 from BentoBoxWorld/copilot/sub-pr-484-again

af015f4

Bump BentoBox dependency to 3.13.0 for MiniMessage support

Fix broken tests: restore showTitle() Adventure API in CheckPhase (no…

5123896

… LegacyComponentSerializer) Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/e8854ea2-7b56-497a-ac76-533846ce7957 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Fix InfoListenerTest: verify via lm.get() instead of deprecated spigo…

06a5bee

…t.sendMessage() Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/b792d2e9-3944-46fa-9f8e-2339f94967e8 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Remove obsolete testOnInfo from InfoListenerTest

7d14d50

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge branch 'develop' into copilot/sub-pr-484

976f3af

Merge pull request #485 from BentoBoxWorld/copilot/sub-pr-484

b69a5f7

Remove custom translate() helper from CheckPhase — let BentoBox handle MiniMessage natively

tastybento requested a review from Copilot April 7, 2026 02:03

Copilot started reviewing on behalf of tastybento April 7, 2026 02:04 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Version 1.23.0#484

Version 1.23.0#484
tastybento wants to merge 18 commits intomasterfrom
develop

tastybento commented Apr 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 6, 2026

Uh oh!

Copilot AI commented Apr 6, 2026

Uh oh!

sonarqubecloud bot commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tastybento commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes since 1.22.0

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 6, 2026

Uh oh!

Copilot AI commented Apr 6, 2026

Uh oh!

sonarqubecloud bot commented Apr 7, 2026

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tastybento commented Apr 5, 2026 •

edited

Loading