Remove custom translate() helper from CheckPhase — let BentoBox handle MiniMessage natively

[Copilot]

• Revert CheckPhase.java to use user.sendMessage() directly (no custom translate() helper)
• Fix CheckPhaseTest: restore showTitle() Adventure API in CheckPhase.setNewPhase()
• Fix InfoListenerTest: replace spigot.sendMessage() verification with lm.get() verification
  • Removed local @Mock private Spigot spigot field and checkSpigotMessage() override
  • Removed unused imports (TextComponent, ArgumentCaptor, List, atLeast, Player.Spigot)
  • testOnInfo: now verifies lm.get(any(User.class), eq("aoneblock.commands.info.count"))
  • testOnInfoOtherAddon: now verifies lm.get() was never called with that key
  • player.spigot() still wired to inherited spigot from CommonTestSetup to prevent NPE in current BentoBox's sendRawMessage()

[tastybento]

@copilot Fix the tests that were broken by this change

[Copilot]

@copilot Fix the tests that were broken by this change

Fixed in commit 5123896. The previous revert was too aggressive and reverted to the deprecated Bukkit sendTitle(), but the tests verify showTitle(any(Title.class)). Restored showTitle() using Component.text(newPhaseName) and Title.title() — no LegacyComponentSerializer needed.

[tastybento]

@copilot There is still a test error:
Error: Failures:
Error: InfoListenerTest.testOnInfo:113->checkSpigotMessage:121->checkSpigotMessage:150 Expected message occurrence mismatch: aoneblock.commands.info.count ==> expected: <1> but was: <0>
[INFO]
Error: Tests run: 394, Failures: 1, Errors: 0, Skipped: 2

[Copilot]

@copilot There is still a test error:
Error: Failures:
Error: InfoListenerTest.testOnInfo:113->checkSpigotMessage:121->checkSpigotMessage:150 Expected message occurrence misma...

Fixed in commit 06a5bee. Updated InfoListenerTest to verify through the LocalesManager (lm.get()) instead of spigot.sendMessage():

• testOnInfo: verify(lm).get(any(User.class), eq("aoneblock.commands.info.count"))
• testOnInfoOtherAddon: verify(lm, never()).get(any(User.class), eq("aoneblock.commands.info.count"))

Removed the local spigot mock, the checkSpigotMessage() override, and all the related unused imports (TextComponent, ArgumentCaptor, List, atLeast, Player.Spigot).

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE