clnvm: Fix up issues when prepping the gl-testserver #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202511-clnvm-hash
branch
2 times, most recently
from
86d3596 to
503d459
Compare
We used to hard-code the CLN version hashes, which is a bit more strict than we want. If we change something on the CI in the way we build the CLN version, or even just recompile, the hashes don't match. Additionally an old clnvm version could not install any CLN versions published after it was last updated. The manifest is a clnvm-independent list of files, their size, checksums, and GPG signature.
- Add signature field to VersionDescriptor to store ASCII-armored PGP signatures from manifest - Load signatures from manifest.json during version updates - Implement _verify_signature() to verify GPG signatures using gnupg library - Add SignatureVerificationFailed exception for signature verification errors - Update _download() to: - Stream downloads to temporary file instead of loading full file in memory - Verify GPG signature after download but before extraction - Warn if signature is not available but do not fail - Update tests to fix CLN_VERSIONS import issue and work with manifest versions This adds cryptographic verification of downloaded Core Lightning binaries, ensuring they haven't been tampered with after leaving the CI/CD pipeline. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
cdecker
force-pushed
the
202511-clnvm-hash
branch
from
503d459 to
102e727
Compare
cdecker
force-pushed
the
202511-clnvm-hash
branch
from
0e95177 to
23e31b8
Compare
Github is removing that image, switched to `macos-latest`
cdecker
force-pushed
the
202511-clnvm-hash
branch
2 times, most recently
from
9589f66 to
436fdb6
Compare
cdecker
force-pushed
the
202511-clnvm-hash
branch
from
436fdb6 to
71303ad
Compare
cdecker
force-pushed
the
202511-clnvm-hash
branch
2 times, most recently
from
412d3eb to
ebad106
Compare
cdecker
force-pushed
the
202511-clnvm-hash
branch
from
ebad106 to
7bf7648
Compare
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using an old
clnvmrather than relying on the one bundled with the PR itself.The hash also changed a number of times, due to ongoing work in how we build and distribute CLN versions for GL, so more changes are queued up.
Closes #633