fix(AlarmModel): correct fromJson initialization (#867)#868
Merged
MarkisDev merged 1 commit intoCCExtractor:mainfrom Apr 19, 2026
Merged
fix(AlarmModel): correct fromJson initialization (#867)#868MarkisDev merged 1 commit intoCCExtractor:mainfrom
MarkisDev merged 1 commit intoCCExtractor:mainfrom
Conversation
This was referenced Mar 12, 2026
MarkisDev
approved these changes
Apr 19, 2026
NihalDR
pushed a commit
to NihalDR/ultimate_alarm_clock
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description
AlarmModel.fromJsonwas callingfromMapwithout using the returned instance, which meant the constructed object was never actually initialized.since most fields in
AlarmModelare declared as late, using fromJson would result in aLateInitializationErrorif accessed.This PR updates
fromJsonto properly delegate tofromMapusing a redirecting constructor, ensuring the model is correctly initializedProposed Changes
Converted
AlarmModel.fromJsonto use Dart's redirecting constructor syntax (: this.fromMap(...)) so the instance actually gets initialized with the decoded data.Fixes #867
Screenshots
N/A - This is a data-layer code fix with no UI changes.
Checklist