fix: prevent memory leak by cancelling all timers in onClose#885
Open
vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
Open
fix: prevent memory leak by cancelling all timers in onClose#885vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a memory leak in the
HomeControllerwhere background timers were not being properly disposed of when the controller was closed.Proposed Changes
onClose()method inlib/app/modules/home/controllers/home_controller.dart..cancel()calls for the periodic_timerand the nullable_delayTimer.Fixes #884
Screenshots
N/A - This is a background performance fix. No visible UI changes, but it improves memory management and battery efficiency.
Checklist