Skip to content

fix: prevent memory leak by cancelling all timers in onClose #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkisDev merged 1 commit into from
Apr 18, 2026
Merged

fix: prevent memory leak by cancelling all timers in onClose #885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/app/modules/home/controllers/home_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,12 @@ class HomeController extends GetxController {
@override
void onClose() {
super.onClose();

if (delayToSchedule != null) {
delayToSchedule!.cancel();
}
// Cancel the periodic UI update timer
_timer.cancel();
// Cancel the delay timer if it was currently waiting
_delayTimer?.cancel();
// Cancel the scheduling delay timer
delayToSchedule?.cancel();
}

Future<void> fetchGoogleCalendars() async {
Expand Down