chore: Enable full reusable quality workflow#689
Open
rubenvdlinde wants to merge 15 commits intodevelopmentfrom
Open
chore: Enable full reusable quality workflow#689rubenvdlinde wants to merge 15 commits intodevelopmentfrom
rubenvdlinde wants to merge 15 commits intodevelopmentfrom
Conversation
Move docusaurus project files from docusaurus/ into docs/ alongside content. Replace local documentation.yml and code-quality.yml with centralized callers. Remove tests.yml.
…nector into development # Conflicts: # docs/docusaurus.config.js
Enable all quality checks (Psalm, PHPStan, phpmetrics, ESLint, PHPUnit, SBOM) via the reusable workflow. Remove standalone sbom.yml as it's now handled by the quality workflow.
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (573 total)
Denied packages
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
- Add .license-overrides.json for @fortawesome/free-solid-svg-icons (CC-BY-4.0 AND MIT) - Add extensions=php to phpcs.xml to exclude JS/CSS files from PHP linting - Disable no-descending-specificity in stylelint config and remove duplicate CSS selector - Run npm audit fix to resolve critical security vulnerabilities
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
Denied packages
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Move 10 class-level BooleanArgumentFlag suppressions to the specific methods that have boolean parameters, improving suppression precision.
Add explanation text to all @SuppressWarnings(PHPMD.StaticAccess) annotations describing the specific vendor/framework static pattern being used. Move dashboard widget suppressions from class-level to method-level on load().
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
…nfig The CI was failing because tests/bootstrap.php did not exist and phpunit.xml used PHPUnit 9 schema with a lowercase tests/unit directory that doesn't match the actual tests/Unit path on case-sensitive Linux.
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Code coverage: 0% (0 / 2 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
PHPUnit Tests
Integration Tests (Newman)
Generated automatically by the Quality workflow.
|
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Code coverage: 0% (0 / 2 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
ConfigurationService now requires 14 parameters (6 mappers, RegisterMapper, SchemaMapper, and 6 configuration handlers). Updated test setUp() to mock all dependencies. Rewrote test assertions to match current method signatures: getEntitiesByConfiguration now indexes by slug, and exportConfiguration returns a components-based structure instead of the old configurationId/entities format.
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Code coverage: 0% (0 / 2 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
…tion - Mock userService->getCurrentUser() instead of userSession->getUser() since the controller delegates to UserService - Mock userService->buildUserDataArray() to return expected data since the controller no longer builds user data directly - Configure IL10N mock with willReturnArgument(0) for pass-through translation so error message assertions work - Configure ICacheFactory mock to return ICache mock so SecurityService constructor succeeds - Configure IRequest->getRemoteAddress() for SecurityService IP lookups - Remove IUser mock methods not on the interface (getUsedSpace, getAvatarScope, canChangeMailAddress, getLanguage, getLocale) - Mock userService->updateUserProperties() for updateMe tests Fixes all 9 PHPUnit failures (3 errors + 6 assertion failures).
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (148 total)
npm dependencies (666 total)
PHPUnit Tests
Code coverage: 0% (0 / 2 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
rjzondervan
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan