chore: Enable full reusable quality workflow

.github/workflows/code-quality.yml

@@ -1,70 +1,25 @@
 name: Code Quality
 
 on:
+  push:
+    branches: [main, development, feature/**, bugfix/**, hotfix/**]
   pull_request:
-    branches: [main, master, development]
-
-concurrency:
-  group: quality-${{ github.head_ref || github.ref }}
-  cancel-in-progress: true
+    branches: [main, beta, development]
+  workflow_dispatch:
 
 jobs:
-  php-checks:
-    name: ${{ matrix.check.name }}
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        check:
-          - { name: "PHP Lint", command: "composer lint" }
-          - { name: "PHPCS", command: "./vendor/bin/phpcs --standard=phpcs.xml" }
-          - { name: "PHPMD", command: "./vendor/bin/phpmd lib text phpmd.xml" }
-          - { name: "Psalm", command: "./vendor/bin/psalm --threads=1 --no-cache --output-format=github" }
-          - { name: "PHPStan", command: "./vendor/bin/phpstan analyse --memory-limit=1G" }
-          - { name: "PHPUnit", command: "./vendor/bin/phpunit --colors=always" }
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.1'
-          extensions: mbstring, xml, ctype, iconv, intl, dom, filter, gd, json, posix, zip, soap
-          tools: composer:v2
-
-      - name: Cache Composer dependencies
-        uses: actions/cache@v4
-        with:
-          path: vendor
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: ${{ runner.os }}-composer-
-
-      - name: Install dependencies
-        run: composer install --no-progress --prefer-dist --optimize-autoloader
-
-      - name: ${{ matrix.check.name }}
-        run: ${{ matrix.check.command }}
-  frontend-quality:
-    name: Frontend Quality
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-          cache: 'npm'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: ESLint
-        run: npm run lint
-
-      - name: Stylelint
-        run: npm run stylelint
+  quality:
+    uses: ConductionNL/.github/.github/workflows/quality.yml@main
+    with:
+      app-name: openconnector
+      php-version: "8.3"
+      nextcloud-test-refs: '["stable32"]'
+      enable-phpcs: false
+      enable-psalm: true
+      enable-phpstan: true
+      enable-phpmetrics: true
+      enable-frontend: true
+      enable-eslint: true
+      enable-phpunit: true
+      enable-sbom: true
+      additional-apps: '[{"repo":"ConductionNL/openregister","app":"openregister"}]'

.github/workflows/documentation.yml

@@ -2,52 +2,12 @@ name: Documentation
 
 on:
   push:
-    branches:
-      - development
+    branches: [documentation]
   pull_request:
-    branches:
-      - development
+    branches: [documentation]
 
 jobs:
   deploy:
-    name: Deploy Documentation
-    runs-on: ubuntu-latest
-    steps:
-      # https://github.com/marketplace/actions/checkout
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      # Verify directory structure
-      - name: List directory structure
-        run: |
-          ls -la
-          ls -la docusaurus/
-
-      # Generate SVG files using PlantUML
-      - name: plantuml
-        id: plantuml
-        uses: grassedge/generate-plantuml-action@v1.5
-        with:
-          message: "Render PlantUML files"
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      # https://github.com/marketplace/actions/docusaurus-builddeploy-action
-      - name: Deploy Docusaurus
-        id: deploy
-        uses: redkubes/docusaurus-deploy-action@v1.2
-        with:
-          source-folder: docusaurus
-          git-user: ${{ github.actor }}
-          git-password: ${{ secrets.GITHUB_TOKEN }}
-          deployment-branch: gh-pages
-
-      # https://github.com/marketplace/actions/create-an-issue
-      - name: Create issue on failure
-        if: failure()
-        uses: JasonEtco/create-an-issue@v2
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          filename: .github/DOCUMENTATION_ISSUE_TEMPLATE.md
+    uses: ConductionNL/.github/.github/workflows/documentation.yml@main
+    with:
+      cname: conductionnl.github.io

.license-overrides.json

@@ -0,0 +1,4 @@
+{
+	"@fortawesome/free-solid-svg-icons": "License is (CC-BY-4.0 AND MIT) — both are approved open-source licenses, compound AND expression not parsed by checker",
+	"apexcharts": "MIT — apexcharts uses MIT license but npm metadata has custom logo URL in license field"
+}

composer.json

@@ -24,7 +24,7 @@
 		"lint": "find . -name \\*.php -not -path './vendor/*' -not -path './vendor-bin/*' -not -path './build/*' -print0 | xargs -0 -n1 php -l",
 		"cs:check": "./vendor/bin/phpcs --standard=phpcs.xml",
 		"cs:fix": "./vendor/bin/phpcbf --standard=phpcs.xml",
-		"phpcs": "./vendor/bin/phpcs --standard=phpcs.xml",
+		"phpcs": "./vendor/bin/phpcs --standard=phpcs.xml --warning-severity=0",
 		"phpcs:fix": "./vendor/bin/phpcbf --standard=phpcs.xml",
 		"phpcs:output": "./vendor/bin/phpcs --standard=phpcs.xml --report=json lib/ 2>/dev/null | tail -1 > phpcs-output.json",
 		"phpmd": "phpmd lib text phpmd.xml || echo 'PHPMD not installed, skipping...'",

lib/Controller/DashboardController.php

@@ -27,7 +27,6 @@
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @SuppressWarnings(PHPMD.ExcessiveParameterList)
  * @SuppressWarnings(PHPMD.MissingImport)
- * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  */
 class DashboardController extends Controller
 {

lib/Controller/EventsController.php

@@ -23,7 +23,6 @@
  * @SuppressWarnings(PHPMD.ShortVariable)
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @SuppressWarnings(PHPMD.TooManyPublicMethods)
- * @SuppressWarnings(PHPMD.UnusedFormalParameter)
  * @SuppressWarnings(PHPMD.UnusedLocalVariable)
  */
 class EventsController extends Controller