Skip to content

PLAT-20201 - chore: migra imagens do dockerhub para ECR#2

Open
luiz-jesus-contaazul wants to merge 1 commit intomasterfrom
PLAT-20201-20260428-135926
Open

PLAT-20201 - chore: migra imagens do dockerhub para ECR#2
luiz-jesus-contaazul wants to merge 1 commit intomasterfrom
PLAT-20201-20260428-135926

Conversation

@luiz-jesus-contaazul
Copy link
Copy Markdown

@luiz-jesus-contaazul luiz-jesus-contaazul commented Apr 28, 2026

Migração automatizada: imagens caninjas/* → ECR.

Substituições

README.md

  • caninjas/ubuntu-br:18.04439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 (origem da tag: kept)

Gerada por scripts/plan_caninjas_to_ecr_migration.py --create-prs.

Summary by CodeRabbit

  • Documentation
    • Updated Build and Deploy instructions in the README to reference a new container image registry for deployment processes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

📝 Walkthrough

Walkthrough

The README.md file's "Build and Deploy" instructions have been updated to change the target Docker image registry from a public Docker registry namespace (caninjas/ubuntu-br:18.04) to an AWS ECR repository (439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04). The build and push commands reference this new registry endpoint instead of the previous one. No other documentation sections or instructions were modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

Warning

⚠️ This pull request might be slop. It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 6-7: The README's Docker push instructions are missing AWS ECR
authentication which causes "no basic auth credentials" errors; update the docs
to include an authentication step using the AWS CLI (run aws ecr
get-login-password --region us-east-2 and pipe to docker login --username AWS
--password-stdin <ECR_URI>) before the shown docker build and docker push
commands so readers authenticate to 439291037095.dkr.ecr.us-east-2.amazonaws.com
first.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2661ac15-cd76-4b1e-ae18-a52f88ed20be

📥 Commits

Reviewing files that changed from the base of the PR and between ba823a8 and 3d88ac4.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md
Comment on lines +6 to +7
$ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
$ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add ECR authentication steps to prevent push failures.

AWS ECR requires authentication before pushing images. Users following the current instructions will encounter "no basic auth credentials" errors when attempting to push.

📝 Proposed documentation update
 ## Build and Deploy
 ```sh
+$ aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin 439291037095.dkr.ecr.us-east-2.amazonaws.com
 $ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
 $ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
</details>

<!-- suggestion_start -->

<details>
<summary>📝 Committable suggestion</summary>

> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

```suggestion
$ aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin 439291037095.dkr.ecr.us-east-2.amazonaws.com
$ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
$ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 6-6: Dollar signs used before commands without showing output

(MD014, commands-show-output)


[warning] 7-7: Dollar signs used before commands without showing output

(MD014, commands-show-output)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 6 - 7, The README's Docker push instructions are
missing AWS ECR authentication which causes "no basic auth credentials" errors;
update the docs to include an authentication step using the AWS CLI (run aws ecr
get-login-password --region us-east-2 and pipe to docker login --username AWS
--password-stdin <ECR_URI>) before the shown docker build and docker push
commands so readers authenticate to 439291037095.dkr.ecr.us-east-2.amazonaws.com
first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant