PLAT-20201 - chore: migra imagens do dockerhub para ECR#2
PLAT-20201 - chore: migra imagens do dockerhub para ECR#2luiz-jesus-contaazul wants to merge 1 commit intomasterfrom
Conversation
📝 WalkthroughWalkthroughThe README.md file's "Build and Deploy" instructions have been updated to change the target Docker image registry from a public Docker registry namespace ( Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Comment Warning |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 6-7: The README's Docker push instructions are missing AWS ECR
authentication which causes "no basic auth credentials" errors; update the docs
to include an authentication step using the AWS CLI (run aws ecr
get-login-password --region us-east-2 and pipe to docker login --username AWS
--password-stdin <ECR_URI>) before the shown docker build and docker push
commands so readers authenticate to 439291037095.dkr.ecr.us-east-2.amazonaws.com
first.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2661ac15-cd76-4b1e-ae18-a52f88ed20be
📒 Files selected for processing (1)
README.md
| $ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 . | ||
| $ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 |
There was a problem hiding this comment.
Add ECR authentication steps to prevent push failures.
AWS ECR requires authentication before pushing images. Users following the current instructions will encounter "no basic auth credentials" errors when attempting to push.
📝 Proposed documentation update
## Build and Deploy
```sh
+$ aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin 439291037095.dkr.ecr.us-east-2.amazonaws.com
$ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
$ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
$ aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin 439291037095.dkr.ecr.us-east-2.amazonaws.com
$ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
$ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 6-6: Dollar signs used before commands without showing output
(MD014, commands-show-output)
[warning] 7-7: Dollar signs used before commands without showing output
(MD014, commands-show-output)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 6 - 7, The README's Docker push instructions are
missing AWS ECR authentication which causes "no basic auth credentials" errors;
update the docs to include an authentication step using the AWS CLI (run aws ecr
get-login-password --region us-east-2 and pipe to docker login --username AWS
--password-stdin <ECR_URI>) before the shown docker build and docker push
commands so readers authenticate to 439291037095.dkr.ecr.us-east-2.amazonaws.com
first.
Migração automatizada: imagens
caninjas/*→ ECR.Substituições
README.mdcaninjas/ubuntu-br:18.04→439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04(origem da tag:kept)Gerada por
scripts/plan_caninjas_to_ecr_migration.py --create-prs.Summary by CodeRabbit