Skip to content

PLAT-20201 - chore: migra imagens do dockerhub para ECR #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luiz-jesus-contaazul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PLAT-20201 - chore: migra imagens do dockerhub para ECR #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ Ubuntu docker image with Brazil/Sao_Paulo locale and pt_BR.UTF-8 lang

## Build and Deploy
```sh
$ docker build -t caninjas/ubuntu-br:18.04 .
$ docker push caninjas/ubuntu-br:18.04
$ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
$ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
Comment on lines +6 to +7
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add ECR authentication steps to prevent push failures.

AWS ECR requires authentication before pushing images. Users following the current instructions will encounter "no basic auth credentials" errors when attempting to push.

📝 Proposed documentation update 
 ## Build and Deploy
 ```sh
+$ aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin 439291037095.dkr.ecr.us-east-2.amazonaws.com
 $ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
 $ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
</details>

<!-- suggestion_start -->

<details>
<summary>📝 Committable suggestion</summary>

> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

```suggestion
$ aws ecr get-login-password --region us-east-2 | docker login --username AWS --password-stdin 439291037095.dkr.ecr.us-east-2.amazonaws.com
$ docker build -t 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04 .
$ docker push 439291037095.dkr.ecr.us-east-2.amazonaws.com/base/ubuntu-br:18.04
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 6-6: Dollar signs used before commands without showing output

(MD014, commands-show-output)

[warning] 7-7: Dollar signs used before commands without showing output

(MD014, commands-show-output)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 6 - 7, The README's Docker push instructions are
missing AWS ECR authentication which causes "no basic auth credentials" errors;
update the docs to include an authentication step using the AWS CLI (run aws ecr
get-login-password --region us-east-2 and pipe to docker login --username AWS
--password-stdin <ECR_URI>) before the shown docker build and docker push
commands so readers authenticate to 439291037095.dkr.ecr.us-east-2.amazonaws.com
first.

```