feat(debugger)!: Add missing data for exception replay#1849
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom Apr 15, 2026
Merged
feat(debugger)!: Add missing data for exception replay#1849gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 5f44d26 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 71.64% 71.64% -0.01%
==========================================
Files 430 431 +1
Lines 68806 68947 +141
==========================================
+ Hits 49297 49396 +99
- Misses 19509 19551 +42
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
bwoebi
force-pushed
the
bob/missing-exception-data
branch
from
b820be7 to
bf55092
Compare
bwoebi
changed the title
Leiyks
approved these changes
Apr 8, 2026
| buffer: &'a mut Vec<DebuggerPayload<'a>>, | ||
| ) -> *mut DebuggerPayload<'a> { | ||
| #[allow(clippy::unwrap_used)] | ||
| buffer.last_mut().unwrap() |
Contributor
There was a problem hiding this comment.
Shouldn't we have proper error handling here just in case ?
| } | ||
|
|
||
| #[no_mangle] | ||
| pub extern "C" fn drop_log_probe_capture_expressions(_: LogProbe) {} |
Contributor
There was a problem hiding this comment.
Should be prefixed by ddog_ I think, same for the drop_span_decoration_probe function below
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/missing-exception-data
branch
from
265067b to
5f44d26
Compare
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
bot
deleted the
bob/missing-exception-data
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"appkey" now redacted and
DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERScan now be supported too.Also including the exception message for exception replay.