Conversation
callumforrester
force-pushed
the
eiger-exts-logic
branch
from
93f8a2d to
6e70a9e
Compare
callumforrester
force-pushed
the
eiger-exts-logic
branch
from
6e70a9e to
e24721c
Compare
| f = {} | ||
| for field_ in fields(self): | ||
| f[field_.name] = vars(self)[field_.name] | ||
| f[field_.name] = { |
There was a problem hiding this comment.
Can we cache this value?
Or else calculate it without the intermediate object?
| device: EigerStream | ||
|
|
||
| @HTTPEndpoint.get(f"/{STREAM_API}" + "/status/{param}") | ||
| async def get_stream_status(self, request: web.Request) -> web.Response: |
There was a problem hiding this comment.
Are we no longer exposing this endpoint?
There was a problem hiding this comment.
It was moved into eiger_adapters.py. I replaced multiple inheritance with one big class.
| from apischema import serialized | ||
| from apischema.fields import with_fields_set | ||
| from apischema.metadata import skip | ||
| from apischema.serialization import serialize |
There was a problem hiding this comment.
apischema? I'll look into whether this can be pulled out easily
There was a problem hiding this comment.
Have pulled it out
There was a problem hiding this comment.
As discussed, pulling this out proved to be more complicated than expected and caused upstream issues with the IOC. It will require a proper look to debug and test those differences. For now I have reset and left this internal use of apischema in. WIP on pulling out here: #66
callumforrester
force-pushed
the
eiger-exts-logic
branch
from
b43bde6 to
32d06b4
Compare
3 participants
Fixes #53
Changes: