Skip to content

fix: scope pgy rollover reads by academic year#1548

Open
Euda1mon1a wants to merge 2 commits intocodex/annual-planning-review-phase3from
codex/pgy-rollover-phase4
Open

fix: scope pgy rollover reads by academic year#1548
Euda1mon1a wants to merge 2 commits intocodex/annual-planning-review-phase3from
codex/pgy-rollover-phase4

Conversation

@Euda1mon1a
Copy link
Owner

Summary

  • add a shared AY-scoped resident PGY resolver with safe fallback to legacy Person.pgy_level
  • switch AcademicBlockService resident rows and AnticipatedLeaveService intern selection to use AY-scoped PGY data and exclude AY-graduated residents
  • add focused backend coverage for AY override/fallback behavior and anticipated-leave regeneration within a target AY

Validation

  • cd backend && .venv/bin/ruff check app/services/person_academic_year_resolver.py app/services/academic_block_service.py app/services/anticipated_leave_service.py tests/services/test_academic_block_service.py tests/services/test_anticipated_leave_service.py
  • cd backend && .venv/bin/pytest tests/services/test_academic_block_service.py -k "get_residents_all or get_residents_filter_by_pgy or get_residents_prefers_academic_year_pgy or get_residents_excludes_academic_year_graduates"
  • cd backend && .venv/bin/pytest tests/services/test_anticipated_leave_service.py

Notes

  • Local dev DB is already at Alembic head (20260321_program_policy_snapshots); this batch updates app reads, not migrations.
  • The broader backend/tests/services/test_academic_block_service.py suite still has pre-existing drift against current models/validator contracts. I logged that in docs/planning/TECHNICAL_DEBT.md as DEBT-031; the focused resident-path tests added here are green.

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Euda1mon1a Euda1mon1a force-pushed the codex/annual-planning-review-phase3 branch from 0efc9f9 to b59c5d8 Compare March 22, 2026 21:00
@Euda1mon1a Euda1mon1a force-pushed the codex/pgy-rollover-phase4 branch from 7796ba6 to 6a8735b Compare March 22, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant