fix: scope pgy rollover reads by academic year#1548
Open
Euda1mon1a wants to merge 2 commits intocodex/annual-planning-review-phase3from
Open
fix: scope pgy rollover reads by academic year#1548Euda1mon1a wants to merge 2 commits intocodex/annual-planning-review-phase3from
Euda1mon1a wants to merge 2 commits intocodex/annual-planning-review-phase3from
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
0efc9f9 to
b59c5d8
Compare
7796ba6 to
6a8735b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Person.pgy_levelAcademicBlockServiceresident rows andAnticipatedLeaveServiceintern selection to use AY-scoped PGY data and exclude AY-graduated residentsValidation
cd backend && .venv/bin/ruff check app/services/person_academic_year_resolver.py app/services/academic_block_service.py app/services/anticipated_leave_service.py tests/services/test_academic_block_service.py tests/services/test_anticipated_leave_service.pycd backend && .venv/bin/pytest tests/services/test_academic_block_service.py -k "get_residents_all or get_residents_filter_by_pgy or get_residents_prefers_academic_year_pgy or get_residents_excludes_academic_year_graduates"cd backend && .venv/bin/pytest tests/services/test_anticipated_leave_service.pyNotes
20260321_program_policy_snapshots); this batch updates app reads, not migrations.backend/tests/services/test_academic_block_service.pysuite still has pre-existing drift against current models/validator contracts. I logged that indocs/planning/TECHNICAL_DEBT.mdasDEBT-031; the focused resident-path tests added here are green.