Conversation
…ed real sim mock encoders?
…encoder and fix network tables not connecting error
…what we found in testing: stow angler and run turret to reverse limit switch both already reset encoder (don't need to do it again)
Sahiltheram
requested review from
MikeKantrowitz,
armadilloz and
batchen1
as code owners
| @@ -0,0 +1,24 @@ | |||
| package frc.robot.commands.angler; | |||
There was a problem hiding this comment.
I'm not sure why this was added, we don't want to use this because it doesn't move the mechanism to the bottom position. the correct command is stowAngler. this should be removed from the PR.
| new LoggableParallelCommandGroup( | ||
| new SetTurretAngle(turret, 0), | ||
| new RunAnglerToReverseLimit(angler) | ||
| new ResetAnglerEncoder(angler) |
There was a problem hiding this comment.
this is incorrect, it has to be stowAngler. the same is true for all the autonomous commands. I'm not sure why this was even changed in this PR, it shouldn't be part of it. This will create conflicts to Michael who is working on the autonomous commands.
I think it would be best to not rename back StowAngler to RunAnglerToReverseLimit and undo all the changes that are related to this.
| @@ -0,0 +1,44 @@ | |||
| // Copyright (c) FIRST and other WPILib contributors. | |||
There was a problem hiding this comment.
Why is this part of this PR?
In fact, the entire intake deployment process changed and this class is no longer in main.
| IntakeDeployerSubsystem intakeDeployerSubsystem, IntakeSubsystem intakeSubsystem, | ||
| ShooterSubsystem shooterSubsystem, TurretSubsystem turretSubsystem, ShootingState shootState) { | ||
| super( | ||
| new SetDeploymentState(intakeDeployerSubsystem, DeploymentState.UP), |
There was a problem hiding this comment.
the intake deployment mechanism changed, please talk to Jackson about what needs to be done here.
| @@ -0,0 +1,32 @@ | |||
| package frc.robot.commands.shooter; | |||
| @@ -0,0 +1,24 @@ | |||
| package frc.robot.commands.turret; | |||
There was a problem hiding this comment.
same comment as the ResetAnglerEncoder.
3 participants
ResetAll Command