refactor: replace magic numbers with named constants in format_relative_time#86
Merged
redpanda-f merged 2 commits intofeat/redpanda/noterminal-version-flagfrom Mar 9, 2026
Merged
Conversation
…ve_time Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor apply feedback on --noterminal flag for version command
refactor: replace magic numbers with named constants in Mar 9, 2026
format_relative_time
redpanda-f
added a commit
that referenced
this pull request
Mar 11, 2026
* feat: introduce --noterminal flag for version command * refactor: replace magic numbers with named constants in `format_relative_time` (#86) * Initial plan * refactor: replace magic numbers with named constants in format_relative_time Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com> * add: notty --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_relative_timeused bare literals60,3600, and86400for time thresholds and divisors, making the logic harder to read and error-prone to modify.Changes
src/main_app/version.rs: Introduced three module-level constants to replace all magic number occurrences:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.