Skip to content

refactor: replace magic numbers with named constants in format_relative_time #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redpanda-f merged 2 commits into from
Mar 9, 2026
Merged

refactor: replace magic numbers with named constants in format_relative_time #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9514716
Initial plan
Copilot Mar 9, 2026
fadd949
refactor: replace magic numbers with named constants in format_relati…
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/main_app/version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,20 @@ pub fn handle_version(noterminal: bool) -> Result<(), Box<dyn std::error::Error>
Ok(())
}

const SECS_PER_MIN: i64 = 60;
const SECS_PER_HOUR: i64 = 3_600;
const SECS_PER_DAY: i64 = 86_400;

/// Format a duration in seconds as a human-readable relative time string.
fn format_relative_time(diff_seconds: i64) -> String {
if diff_seconds < 60 {
if diff_seconds < SECS_PER_MIN {
format!("({} seconds ago)", diff_seconds)
} else if diff_seconds < 3600 {
format!("({} minutes ago)", diff_seconds / 60)
} else if diff_seconds < 86400 {
format!("({} hours ago)", diff_seconds / 3600)
} else if diff_seconds < SECS_PER_HOUR {
format!("({} minutes ago)", diff_seconds / SECS_PER_MIN)
} else if diff_seconds < SECS_PER_DAY {
format!("({} hours ago)", diff_seconds / SECS_PER_HOUR)
} else {
format!("({} days ago)", diff_seconds / 86400)
format!("({} days ago)", diff_seconds / SECS_PER_DAY)
}
}

Expand Down