Skip to content

Add more slayer monsters and braindeath island #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 10 commits into from
Mar 28, 2026

Formatting

44ecfd6
Select commit
Loading
Failed to load commit list.
Merged

Add more slayer monsters and braindeath island #931

Formatting
44ecfd6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 28, 2026 in 0s

37.90% (-0.12%) compared to 9b3aefe

View this Pull Request on Codecov

37.90% (-0.12%) compared to 9b3aefe

Details

Codecov Report

❌ Patch coverage is 9.71223% with 251 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.90%. Comparing base (9b3aefe) to head (44ecfd6).

Files with missing lines Patch % Lines
...ontent/area/morytania/port_phasmatys/PiratePete.kt 2.73% 71 Missing ⚠️
...content/area/morytania/braindeath_island/Brewer.kt 2.81% 69 Missing ⚠️
...halin/draynor_village/manor/ProfessorOddenstein.kt 7.14% 26 Missing ⚠️
...rea/morytania/braindeath_island/ZombieProtester.kt 17.24% 24 Missing ⚠️
.../area/morytania/braindeath_island/CaptainDonnie.kt 12.50% 14 Missing ⚠️
...ent/area/morytania/mort_myre_swamp/FeralVampyre.kt 17.64% 14 Missing ⚠️
...ea/misthalin/draynor_village/manor/DraynorManor.kt 22.22% 7 Missing ⚠️
...tent/area/morytania/port_phasmatys/TorturedSoul.kt 37.50% 5 Missing ⚠️
...area/misthalin/draynor_village/manor/Killerwatt.kt 42.85% 4 Missing ⚠️
...nt/area/morytania/braindeath_island/FeverSpider.kt 42.85% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
Files with missing lines Coverage Δ
...regs/voidps/engine/data/config/CombatDefinition.kt 0.00% <0.00%> (ø)
...orld/gregs/voidps/engine/data/definition/Tables.kt 46.25% <0.00%> (ø)
...me/src/main/kotlin/content/entity/combat/Target.kt 35.23% <0.00%> (-0.34%) ⬇️
...otlin/content/skill/constitution/drink/Overload.kt 23.43% <0.00%> (ø)
...ain/kotlin/content/skill/firemaking/LightSource.kt 26.66% <0.00%> (ø)
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 51.03% <0.00%> (-0.72%) ⬇️
...voidps/engine/data/definition/CombatDefinitions.kt 0.00% <0.00%> (ø)
...ame/src/main/kotlin/content/skill/slayer/Slayer.kt 22.03% <0.00%> (-1.19%) ⬇️
...area/misthalin/draynor_village/manor/Killerwatt.kt 42.85% <42.85%> (ø)
...nt/area/morytania/braindeath_island/FeverSpider.kt 42.85% <42.85%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #931      +/-   ##
============================================
- Coverage     38.01%   37.90%   -0.12%     
- Complexity     7936     7950      +14     
============================================
  Files          1627     1637      +10     
  Lines         64950    65225     +275     
  Branches      16233    16289      +56     
============================================
+ Hits          24692    24722      +30     
- Misses        34744    34989     +245     
  Partials       5514     5514
Components Coverage Δ
Content 35.87% <9.89%> (-0.17%) ⬇️
Engine 45.62% <0.00%> (-0.02%) ⬇️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov