Skip to content

Conversation

@Wulian233
Copy link
Contributor

在下载世界、模组、资源包时,都会使用对应的类别,但是 SHADER_PACK 忘记 case 了,导致默认是模组下载

效果图片 屏幕截图 2025-12-21 085035 屏幕截图 2025-12-21 085246

@Calboot
Copy link
Contributor

Calboot commented Dec 21, 2025

How about #4980 ?
这个问题实际上是 #4680 的一部分

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where downloading shader packs displayed an incorrect dialog title showing "mod download" instead of "shader download". The fix adds proper handling for the SHADER_PACK type across the codebase.

  • Added SHADER_PACK enum value to RemoteModRepository.Type
  • Updated the download dialog title logic to include a case for shader packs
  • Added localization strings for shader pack download titles in all language files (English, Simplified Chinese, Traditional Chinese, and Classical Chinese)

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/RemoteModRepository.java Added SHADER_PACK enum value to the Type enum
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java Updated switch statement to include SHADER_PACK case for setting the correct dialog title
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/HMCLLocalizedDownloadListPage.java Added ofShaderPack factory method to create shader pack download pages
HMCL/src/main/java/org/jackhuang/hmcl/ui/download/DownloadPage.java Updated shader tab to use the new ofShaderPack factory method instead of the generic DownloadListPage
HMCL/src/main/resources/assets/lang/I18N.properties Added English translation for shader pack download title
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Added Simplified Chinese translation for shader pack download title
HMCL/src/main/resources/assets/lang/I18N_zh.properties Added Traditional Chinese translation for shader pack download title
HMCL/src/main/resources/assets/lang/I18N_lzh.properties Added Classical Chinese translation for shader pack download title

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit 8923be5 into HMCL-dev:main Jan 2, 2026
8 checks passed
@Wulian233 Wulian233 deleted the text branch January 2, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants