Merged
Conversation
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Fix ActionIfIsolated::DoNothing infinite loop when all species are isolated
Rewrite speciation feature
…Cargo.toml Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
…ayered-observer Add QoL trait impls to `LayeredObserver`
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Add examples to CI workflow, register missing example metadata, and add comprehensive test suite
There was a problem hiding this comment.
Pull request overview
This PR updates genetic-rs toward the 1.4.0 release by introducing a redesigned speciation core (shared in genetic-rs-common), updating builtin speciated eliminator/repopulator behavior, and adding a larger integration-test suite plus CI coverage for examples.
Changes:
- Add new
speciationmodule ingenetic-rs-common(Speciated,SpeciatedPopulation) and re-exportSpeciatedvia the prelude under thespeciationfeature. - Implement/update speciated builtin components (
SpeciatedFitnessEliminator,SpeciatedCrossoverRepopulator) and observer QoL (FitnessObserverlayering trait impls). - Add integration tests + feature-gated
[[test]]entries and run examples in CI; update speciation example + README text.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| genetic-rs/tests/speciation.rs | New integration tests covering speciated population grouping/iteration and speciated eliminator invariants. |
| genetic-rs/tests/simulation.rs | New integration tests for GeneticSim invariants and FitnessEliminator behavior. |
| genetic-rs/tests/repopulator.rs | New integration tests for builtin repopulators and FromParent. |
| genetic-rs/tests/knockout.rs | New integration tests for knockout eliminator behavior and helpers. |
| genetic-rs/tests/eliminator.rs | Adds tests validating new LayeredObserver trait impls (Default/Clone/Debug/Eq). |
| genetic-rs/examples/speciation.rs | Updates speciation example to new divergence-based API and new speciated wrappers. |
| genetic-rs/Cargo.toml | Adds [[example]] and [[test]] entries with required-features for gated execution. |
| genetic-rs-common/src/speciation.rs | New shared speciation API: Speciated + SpeciatedPopulation utilities. |
| genetic-rs-common/src/prelude.rs | Re-exports Speciated behind the speciation feature. |
| genetic-rs-common/src/lib.rs | Exposes new speciation module behind the speciation feature. |
| genetic-rs-common/src/builtin/repopulator.rs | Adds FromParent, Default for crossover repopulator, and rewrites speciated crossover repopulator logic. |
| genetic-rs-common/src/builtin/eliminator.rs | Adds closure observer impl and derives for LayeredObserver; introduces SpeciatedFitnessEliminator. |
| README.md | Adds ecosystem section and updates “minimal usage” wording. |
| .github/workflows/ci-cd.yml | Adds a job to run examples in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@HyperCodec I've opened a new pull request, #149, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
|
@HyperCodec I've opened a new pull request, #150, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Broaden FitnessObserver blanket impl to accept FnMut closures
…rce invariants Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Restrict `SpeciatedPopulation::species` to enforce non-empty species invariant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many small internal rewrites/QoL features, as well as a complete rewrite of the speciation feature with tons of new functionality.