Broaden FitnessObserver blanket impl to accept FnMut closures#150
Merged
HyperCodec merged 2 commits intodevfrom Mar 10, 2026
Merged
Broaden FitnessObserver blanket impl to accept FnMut closures#150HyperCodec merged 2 commits intodevfrom
HyperCodec merged 2 commits intodevfrom
Conversation
Merged
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from PR #148 for update 1.4.0
Broaden FitnessObserver blanket impl to accept FnMut closures
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blanket
FitnessObserverimpl was bounded onFn, which excludedFnMutclosures — a common pattern for observers that accumulate state (counters, logs, running stats, etc.), forcing unnecessary use ofRefCellor similar wrappers.Change
FitnessObserver<G>impl fromFn(&[(G, f32)])toFnMut(&[(G, f32)])This is a safe widening: every
Fnis alsoFnMut, so no existing code breaks. Theobservemethod already takes&mut self, makingFnMutthe natural bound.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.