Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables combining
FusionStyles through the interfaceFusionStyle(::FusionStyle, ::FusionStyle), inspired by the interface for combiningBroadcastStyles: https://docs.julialang.org/en/v1/manual/interfaces/#writing-binary-broadcasting-rules. Additionally, this PR combines the fusion styles of the inputs of matricized tensor contraction to determine a common fusion style (which should ensure the bases are compatible, assuming the matricization is defined properly).Also add ITensorNetworksNext.jl as a downstream test.
This addresses an issue noticed in ITensor/ITensorNetworksNext.jl#27.
In the future, we should add a higher level interface for combining fusion styles based on the rules defined in this PR, see https://github.com/JuliaLang/julia/blob/98519108869cae69fa0622acdb3f1d24e174996d/base/broadcast.jl#L413-L483.