Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/IntegrationTest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 'FusionTensors'
- 'GradedArrays'
- 'ITensorBase'
- 'ITensorNetworksNext'
- 'KroneckerArrays'
- 'NamedDimsArrays'
uses: "ITensor/ITensorActions/.github/workflows/IntegrationTest.yml@main"
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "TensorAlgebra"
uuid = "68bd88dc-f39d-4e12-b2ca-f046b68fcc6a"
authors = ["ITensor developers <support@itensor.org> and contributors"]
version = "0.6.5"
version = "0.6.6"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
5 changes: 1 addition & 4 deletions src/contract/contract.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ end
Matricize() = Matricize(ReshapeFusion())

function default_contract_algorithm(A1::Type{<:AbstractArray}, A2::Type{<:AbstractArray})
style1 = FusionStyle(A1)
style2 = FusionStyle(A2)
style1 == style2 || error("Styles must match.")
return Matricize(style1)
return Matricize(FusionStyle(FusionStyle(A1), FusionStyle(A2)))
end

# Required interface if not using
Expand Down
7 changes: 3 additions & 4 deletions src/matricize.jl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ abstract type FusionStyle end

FusionStyle(x) = FusionStyle(typeof(x))
FusionStyle(T::Type) = throw(MethodError(FusionStyle, (T,)))
FusionStyle(style1::Style, style2::Style) where {Style <: FusionStyle} = Style()
FusionStyle(style1::FusionStyle, style2::FusionStyle) = ReshapeFusion()

# ======================================= misc ========================================
function trivial_axis(
Expand Down Expand Up @@ -72,10 +74,7 @@ function tensor_product_axis(r1::AbstractUnitRange, r2::AbstractUnitRange)
return tensor_product_axis(style, r1, r2)
end
function tensor_product_fusionstyle(r1::AbstractUnitRange, r2::AbstractUnitRange)
style1 = FusionStyle(r1)
style2 = FusionStyle(r2)
style1 == style2 || error("Styles must match.")
return style1
return FusionStyle(FusionStyle(r1), FusionStyle(r2))
end

function fused_axis(
Expand Down
28 changes: 28 additions & 0 deletions test/test_fusionstyle.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
using TensorAlgebra: TensorAlgebra as TA, FusionStyle, Matricize, ReshapeFusion
using Test: @test, @testset

module FusionStyleTestUtils
using TensorAlgebra: TensorAlgebra as TA
struct MyArray{T, N, A <: AbstractArray{T, N}} <: AbstractArray{T, N}
parent::A
end
struct MyArrayFusion <: TA.FusionStyle end
TA.FusionStyle(::Type{<:MyArray}) = MyArrayFusion()
end
using .FusionStyleTestUtils: MyArray, MyArrayFusion

@testset "FusionStyle" begin
a1 = randn(2, 2)
a2 = MyArray(randn(2, 2))
@test FusionStyle(a1) ≡ ReshapeFusion()
@test FusionStyle(a2) ≡ MyArrayFusion()
@test FusionStyle(typeof(a1)) ≡ ReshapeFusion()
@test FusionStyle(ReshapeFusion(), ReshapeFusion()) ≡ ReshapeFusion()
@test FusionStyle(MyArrayFusion(), MyArrayFusion()) ≡ MyArrayFusion()
@test FusionStyle(MyArrayFusion(), ReshapeFusion()) ≡ ReshapeFusion()
@test FusionStyle(ReshapeFusion(), MyArrayFusion()) ≡ ReshapeFusion()
@test TA.default_contract_algorithm(typeof(a1), typeof(a1)) ≡ Matricize(ReshapeFusion())
@test TA.default_contract_algorithm(typeof(a1), typeof(a2)) ≡ Matricize(ReshapeFusion())
@test TA.default_contract_algorithm(typeof(a2), typeof(a1)) ≡ Matricize(ReshapeFusion())
@test TA.default_contract_algorithm(typeof(a2), typeof(a2)) ≡ Matricize(MyArrayFusion())
end
Loading