chore: harden sync workflow — pin OS, add timeout, npm ci#15
Merged
nbrieussel merged 2 commits intomainfrom Apr 14, 2026
Merged
chore: harden sync workflow — pin OS, add timeout, npm ci#15nbrieussel merged 2 commits intomainfrom
nbrieussel merged 2 commits intomainfrom
Conversation
nbrieussel
force-pushed
the
chore/workflow-hardening-and-upgrade
branch
from
eed755d to
db272fd
Compare
3 tasks
- ubuntu-latest → ubuntu-24.04 (reproducible runner image) - timeout-minutes: 30 (prevent runaway jobs) - npm install → npm ci (locked deps, faster, deterministic) Closes #4. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tested in PR #15 dry-run gate. createProbot() still initializes with a null logger despite PR #949. Stay on 2.1.17 until a release boots cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nbrieussel
force-pushed
the
chore/workflow-hardening-and-upgrade
branch
from
2a8d119 to
8820c31
Compare
nbrieussel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Changes
ubuntu-latest→ubuntu-24.04(reproducible runner image)timeout-minutes: 30(prevent runaway jobs)npm install→npm ci(locked deps, deterministic)Notes
TypeError: Cannot read properties of null (reading 'info'). Staying on 2.1.17. Issue updated with findings.Dry-run checklist
gh workflow run safe-settings-sync.yml --repo IntegratedDynamic/admin --ref chore/workflow-hardening-and-upgrade -f nop=true