Skip to content

chore: harden sync workflow — pin OS, add timeout, npm ci #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbrieussel merged 2 commits into from
Apr 14, 2026
+7 −6
Merged

chore: harden sync workflow — pin OS, add timeout, npm ci #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08aa790
chore: harden sync workflow — pin OS, add timeout, npm ci
Apr 14, 2026
8820c31
docs: 2.1.19 not safe — null.info crash persists
Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/safe-settings-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ on:
jobs:
sync:
name: Sync org settings${{ github.event.inputs.nop == 'true' && ' (dry-run)' || '' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: read
env:
Expand All @@ -45,7 +46,7 @@ jobs:
cache-dependency-path: ${{ env.SAFE_SETTINGS_CODE_DIR }}/package-lock.json

- name: Install dependencies
run: npm install
run: npm ci
working-directory: ${{ env.SAFE_SETTINGS_CODE_DIR }}

- name: Run full sync
Expand Down
8 changes: 4 additions & 4 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ These are **already worked around** in this repo — do not undo them:
(concatenates, not replaces). If set in both `settings.yml` and a suborg file, `nbrieussel` ends
up listed twice and the API rejects it. Set bypass **only** in `settings.yml`.

4. **probot v14 full-sync break** — fixed in 2.1.19+ via
[PR #949](https://github.com/github/safe-settings/pull/949). The version is currently pinned to
`2.1.17` in `.github/workflows/safe-settings-sync.yml` (`SAFE_SETTINGS_VERSION`). Upgrading to
`2.1.19` is safe; always do a dry-run first.
4. **probot v14 full-sync break** — PR #949 claimed to fix this but 2.1.19 still crashes with
`TypeError: Cannot read properties of null (reading 'info') at performFullSync`. The octokit
`.rest.*` calls were fixed but `createProbot()` still initializes with a null logger. **Stay on
`2.1.17`** until a release actually boots cleanly in NOP mode.

## Open hygiene issues (tracked in this repo's GitHub Issues)

Expand Down
Loading