Convert enzyme tests to React Testing Library with help from Claude Code for ontology dir components#1994
Open
Convert enzyme tests to React Testing Library with help from Claude Code for ontology dir components#1994
Conversation
labkey-nicka
approved these changes
May 5, 2026
| fetchParentPaths: jest.fn().mockResolvedValue([]), | ||
| })); | ||
|
|
||
| jest.mock('../files/FileTree', () => ({ |
Contributor
There was a problem hiding this comment.
This mock is not quite right. This is resulting in an error being logged during the test.
I recommend declaring the mocked component as a class. This needs to be done inline to the mock call do to how jest hoists definitions.
jest.mock('../files/FileTree', () => {
// Declaring as a class since functional components do not receive refs (which FileTree does)
class mockFileTree extends React.PureComponent {
render() {
return <div className="mock-file-tree" />;
}
}
return {
DEFAULT_ROOT_PREFIX: '|root',
FileTree: mockFileTree,
};
});| test('node not selected', () => { | ||
| const testnode = { data: { code: 'test' } }; | ||
| const testFilters = new Map<string, PathModel>().set('nope', new PathModel()); | ||
| const { container } = render(<FilterIcon node={testnode} filters={testFilters} />); |
Contributor
There was a problem hiding this comment.
Lint warning. I know you commonly wait to lint at the end but I wasn't sure in this case since it is all new code.
Contributor
Author
There was a problem hiding this comment.
yes, I still plan to run the linting pass right before merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Convert spec.tsx enzyme test files to RTL tests with the help from Claude Code for the ontology dir components.
Related Pull Requests