Skip to content

launcher: Await user input on error#7

Open
wjt wants to merge 1 commit intoLilithSilver:mainfrom
wjt:launcher-await-input-on-error
Open

launcher: Await user input on error#7
wjt wants to merge 1 commit intoLilithSilver:mainfrom
wjt:launcher-await-input-on-error

Conversation

@wjt
Copy link
Copy Markdown
Contributor

@wjt wjt commented Mar 25, 2026

Previously, if the Godot editor failed to launch (perhaps because it has not been downloaded!), the terminal window would disappear too quickly for the error message to be legible.

Add the same "Press Enter to continue..." prompt as in the updater, but only in
the error case. Handle two error paths:

  • The process could not be spawned
  • The process was spawned but exited with a non-zero status

@wjt
Copy link
Copy Markdown
Contributor Author

wjt commented Mar 25, 2026

The case where we hit this was that I manually prepared a moddable-pong-with-patchwork bundle from @jgbourque as follows:

  1. git clone https://github.com/endlessm/moddable-pong.git
  2. Copy update-patchwork.exe and launch-patchwork.exe into the project & update .gitignore
  3. Zip up the folder
  4. Send it to Justin

I meant to tell Justin to run update-patchwork.exe (to actually install the addon & editor) before launch-patchwork.exe. But I did not. So when he tried to use launch-patchwork.exe it just flashed a terminal on the screen for a split second.

@wjt wjt marked this pull request as draft March 25, 2026 15:51
Previously, if the Godot editor failed to launch (perhaps because it has not
been downloaded!), the terminal window would disappear too quickly for the error
message to be legible.

Add the same "Press Enter to continue..." prompt as in the updater, but only in
the error case. Handle two error paths:

- The process could not be spawned
- The process was spawned but exited with a non-zero status
@wjt wjt force-pushed the launcher-await-input-on-error branch from 3210190 to 2d622bb Compare March 25, 2026 17:10
@wjt wjt marked this pull request as ready for review March 25, 2026 17:12
@wjt
Copy link
Copy Markdown
Contributor Author

wjt commented Mar 25, 2026

I must confess to only having tested this on Linux!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant