Open
Conversation
Contributor
Author
|
The case where we hit this was that I manually prepared a moddable-pong-with-patchwork bundle from @jgbourque as follows:
I meant to tell Justin to run |
Previously, if the Godot editor failed to launch (perhaps because it has not been downloaded!), the terminal window would disappear too quickly for the error message to be legible. Add the same "Press Enter to continue..." prompt as in the updater, but only in the error case. Handle two error paths: - The process could not be spawned - The process was spawned but exited with a non-zero status
3210190 to
2d622bb
Compare
Contributor
Author
|
I must confess to only having tested this on Linux! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the Godot editor failed to launch (perhaps because it has not been downloaded!), the terminal window would disappear too quickly for the error message to be legible.
Add the same "Press Enter to continue..." prompt as in the updater, but only in
the error case. Handle two error paths: