Skip to content

fix(StageWinnings): Correctly display non-score matches#7234

Open
hjpalpha wants to merge 1 commit intomainfrom
fix-stageWinnings-edge-case
Open

fix(StageWinnings): Correctly display non-score matches#7234
hjpalpha wants to merge 1 commit intomainfrom
fix-stageWinnings-edge-case

Conversation

@hjpalpha
Copy link
Collaborator

Summary

reported on discord: https://discord.com/channels/93055209017729024/268719633366777856/1480911245598130349

How did you test this change?

dev

@hjpalpha hjpalpha requested review from a team as code owners March 10, 2026 13:51
Copy link
Collaborator

@mbergen mbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd probably need a way to treat a W-FF score as if it was a regular score (e.g. 2-0 in a Bo3), right?
We can add that if there's a specific request tho, this seems fine for now

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Mar 10, 2026

We'd probably need a way to treat a W-FF score as if it was a regular score (e.g. 2-0 in a Bo3), right? We can add that if there's a specific request tho, this seems fine for now

you can asign it a value like any normal score already
the calculation was not at fault
only the display failed

image

@mbergen
Copy link
Collaborator

mbergen commented Mar 10, 2026

Ah great, missed that part!

@mbergen mbergen changed the title fix(StageWinnings): error on non score matches fix(StageWinnings): Correctly display non-score matches Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants