Skip to content

fix(StageWinnings): Correctly display non-score matches #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eetwalt merged 1 commit into from
Mar 19, 2026
Merged

fix(StageWinnings): Correctly display non-score matches #7234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lua/wikis/commons/Widget/StageWinnings.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,15 @@ end
function StageWinnings._detailedScores(scoresTable)
---@type {wins: integer, losses: integer, count: integer}
local scoreInfos = Array.extractValues(Table.map(scoresTable, function(score, count)
local wins, losses = score:match('(%d+)%-(%d+)')
return score, {wins = tonumber(wins), losses = tonumber(losses), count = count}
local wins, losses = unpack(Array.parseCommaSeparatedString(score, '-'))
return score, {wins = tonumber(wins) or wins, losses = tonumber(losses) or losses, count = count}
end))
table.sort(scoreInfos, function(a, b)
if (not Logic.isNumeric(a.wins)) or (not Logic.isNumeric(a.losses)) then
return false
elseif (not Logic.isNumeric(b.wins)) or (not Logic.isNumeric(b.losses)) then
return true
end
local diffA = a.wins - a.losses
local diffB = b.wins - b.losses
if diffA ~= diffB then
Expand Down
Loading