Make WebController ranking methods private

[AngeloTadeucci]

Change the visibility of several ranking and mentor-related methods in WebController from public to private to restrict external access and improve encapsulation. Affected methods: Trophy, PersonalTrophy, GuildTrophy, PersonalGuildTrophy, and MenteeList.

Summary by CodeRabbit

• Refactor
  • Internal code organization updates with no changes to user-facing functionality or behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13a78e82-90ac-4db3-bf68-2f677f51d8a7

📥 Commits

Reviewing files that changed from the base of the PR and between 6590f86 and 68c8afb.

📒 Files selected for processing (1)

• Maple2.Server.Web/Controllers/WebController.cs

---

📝 Walkthrough

Walkthrough

Five ranking-related methods (Trophy, PersonalTrophy, GuildTrophy, PersonalGuildTrophy, and MenteeList) in WebController are changed from public to private visibility. Internal method invocations within the class remain unchanged; no functional modifications.

Changes

Cohort / File(s)	Summary
Access Control Restriction Maple2.Server.Web/Controllers/WebController.cs	Five ranking-related methods (Trophy, PersonalTrophy, GuildTrophy, PersonalGuildTrophy, MenteeList) changed from public to private, restricting external access while maintaining internal call sites and return types.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• Add guild trophy ranking and caching #633: Adds guild trophy ranking and caching features, introducing or modifying the same GuildTrophy and PersonalGuildTrophy methods whose visibility is now being restricted.

Poem

🐰 Five methods close their public doors,
Now private, tucked away indoors,
Trophy hunters still find their way,
Through internal calls throughout the day,
Less exposure, cleaner code—hooray!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: making WebController ranking methods private to improve encapsulation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch web-controller-private-methods

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}