Skip to content

Make WebController ranking methods private #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AngeloTadeucci merged 1 commit into from
Mar 6, 2026
Merged

Make WebController ranking methods private #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Maple2.Server.Web/Controllers/WebController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ private static IResult HandleUnknownMode(UgcType mode) {
#endregion

#region Ranking
public ByteWriter Trophy(string userName) {
private ByteWriter Trophy(string userName) {
string cacheKey = $"Trophy_{userName ?? "all"}";

if (!cache.TryGetValue(cacheKey, out byte[]? cachedData)) {
Expand All @@ -312,7 +312,7 @@ public ByteWriter Trophy(string userName) {
return result;
}

public ByteWriter PersonalTrophy(long characterId) {
private ByteWriter PersonalTrophy(long characterId) {
string cacheKey = $"PersonalTrophy_{characterId}";

if (!cache.TryGetValue(cacheKey, out byte[]? cachedData)) {
Expand All @@ -328,7 +328,7 @@ public ByteWriter PersonalTrophy(long characterId) {
return result;
}

public ByteWriter GuildTrophy(string userName) {
private ByteWriter GuildTrophy(string userName) {
if (!string.IsNullOrEmpty(userName)) {
string cacheKey = $"GuildTrophy_{userName}";

Expand Down Expand Up @@ -359,7 +359,7 @@ public ByteWriter GuildTrophy(string userName) {
return InGameRankPacket.GuildTrophy(GetCachedGuildTrophyRankings());
}

public ByteWriter PersonalGuildTrophy(long characterId) {
private ByteWriter PersonalGuildTrophy(long characterId) {
string cacheKey = $"PersonalGuildTrophy_{characterId}";

if (!cache.TryGetValue(cacheKey, out byte[]? cachedData)) {
Expand Down Expand Up @@ -397,7 +397,7 @@ private IList<GuildTrophyRankInfo> GetCachedGuildTrophyRankings() {
}
#endregion

public ByteWriter MenteeList(long accountId, long characterId) {
private ByteWriter MenteeList(long accountId, long characterId) {
using GameStorage.Request db = gameStorage.Context();
IList<long> list = db.GetMentorList(accountId, characterId);

Expand Down
Loading