Skip to content

Improve output from mariadb-secure-installation to be more honest #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottok wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −10
Open

Improve output from mariadb-secure-installation to be more honest #4457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions scripts/mysql_secure_installation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,8 @@ set_root_password() {
remove_anonymous_users() {
do_query "DELETE FROM mysql.global_priv WHERE User='';"
if [ $? -eq 0 ]; then
echo " ... Success!"
echo "SQL executed without errors!"
echo "The operation might have been successful, or it might have not done anything."
else
echo " ... Failed!"
clean_and_exit
Expand All @@ -350,7 +351,8 @@ remove_anonymous_users() {
remove_remote_root() {
do_query "DELETE FROM mysql.global_priv WHERE User='root' AND Host NOT IN ('localhost', '127.0.0.1', '::1');"
if [ $? -eq 0 ]; then
echo " ... Success!"
echo "SQL executed without errors!"
echo "The operation might have been successful, or it might have not done anything."
else
echo " ... Failed!"
fi
Expand All @@ -360,15 +362,17 @@ remove_test_database() {
echo " - Dropping test database..."
do_query "DROP DATABASE IF EXISTS test;"
if [ $? -eq 0 ]; then
echo " ... Success!"
echo "SQL executed without errors!"
echo "The operation might have been successful, or it might have not done anything."
else
echo " ... Failed! Not critical, keep moving..."
fi

echo " - Removing privileges on test database..."
do_query "DELETE FROM mysql.db WHERE Db='test' OR Db='test\\_%'"
if [ $? -eq 0 ]; then
echo " ... Success!"
echo "SQL executed without errors!"
echo "The operation might have been successful, or it might have not done anything."
else
echo " ... Failed! Not critical, keep moving..."
fi
Expand Down Expand Up @@ -413,12 +417,10 @@ prepare
set_echo_compat

echo
echo "NOTE: RUNNING ALL PARTS OF THIS SCRIPT IS RECOMMENDED FOR ALL MariaDB"
echo " SERVERS IN PRODUCTION USE! PLEASE READ EACH STEP CAREFULLY!"
echo "NOTE: MariaDB is secure by default. Running this script is"
echo " useless at best, and misleading at worst."
echo
echo "In order to log into MariaDB to secure it, we'll need the current"
echo "password for the root user. If you've just installed MariaDB, and"
echo "haven't set the root password yet, you should just press enter here."
echo "Enter root user password or leave blank:"
echo

get_root_password
Expand Down Expand Up @@ -450,7 +452,7 @@ else
emptypass=0
do_query "UPDATE mysql.global_priv SET priv=json_set(priv, '$.password_last_changed', UNIX_TIMESTAMP(), '$.plugin', 'mysql_native_password', '$.authentication_string', 'invalid', '$.auth_or', json_array(json_object(), json_object('plugin', 'unix_socket'))) WHERE User='root';"
if [ $? -eq 0 ]; then
echo "Enabled successfully!"
echo "Enabled successfully (or at least no errors was emitted)!"
echo "Reloading privilege tables.."
reload_privilege_tables
if [ $? -eq 1 ]; then
Expand Down