Calculate wind vector speed and direction from U and V compts#2119
Open
Simon Osborne (mo-sro) wants to merge 26 commits into
Open
Calculate wind vector speed and direction from U and V compts#2119Simon Osborne (mo-sro) wants to merge 26 commits into
Simon Osborne (mo-sro) wants to merge 26 commits into
Conversation
Contributor
|
|
Simon Osborne (mo-sro)
changed the title
Simon Osborne (mo-sro)
changed the title
Collaborator
David Flack (daflack)
left a comment
David Flack (daflack)
left a comment
There was a problem hiding this comment.
Looking good, a few comments to think about for improving the operator, and some tests will be needed as well to show it works as expected.
Refactor calculate_vector_wind to calculate_vector_wind_from_list and update its handling of CubeList input. so that U and V are separate arguments.
Updated docstring to correct terminology and improve clarity.
Updated docstring formatting and improved readability.
Updated docstring to correct terminology and formatting.
Extract U and V components from CubeList.
Add error handling to exception in wind.py
Added argument descriptions for u_cube and v_cube in the wind function.
Co-authored-by: David Flack <77390156+daflack@users.noreply.github.com>
8 tasks
Contributor
Author
set of 6 tests now in place for the new calculate_wind_vector function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.