Add stable env DeviceSegmentedSort::Pairs 1/2#8003
Add stable env DeviceSegmentedSort::Pairs 1/2#8003gonidelis wants to merge 3 commits intoNVIDIA:mainfrom
DeviceSegmentedSort::Pairs 1/2#8003Conversation
DeviceSegmentedSort::Pairs and friends
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Important: can we add one representative MR/temp-storage env test here too? At the moment this only checks stream propagation, but these APIs also go through dispatch_with_env, so the memory-resource path is currently untested.
There was a problem hiding this comment.
@NaderAlAwar isn't the mr tested by default in lid_2 here?
cccl/cub/test/catch2_test_env_launch_helper.h
Lines 466 to 467 in e1a7506
There was a problem hiding this comment.
That MR coverage exists for the DECLARE_LAUNCH_WRAPPER / TEST_LAUNCH path, but this file explicitly does not use that path, so it doesn’t apply here. This means that there is no lid_2 variant here.
There was a problem hiding this comment.
Actually wait, I was wrong, I saw an older version of the PR, we do have DECLARE_LAUNCH_WRAPPER here. I still think we should not use lid_2 for similar reasons to here #8286 (comment)
06fd843 to
3beffdc
Compare
DeviceSegmentedSort::Pairs and friendsDeviceSegmentedSort::Pairs
🥳 CI Workflow Results🟩 Finished in 2h 08m: Pass: 100%/269 | Total: 6d 11h | Max: 2h 08m | Hits: 78%/177097See results here. |
DeviceSegmentedSort::PairsDeviceSegmentedSort::Pairs 1/2
fixes #7551
Follows exactly same logic as #8002
Let's merge it after this one ^^^