Skip to content

Add stable env DeviceSegmentedSort::Pairs 1/2#8003

Open
gonidelis wants to merge 3 commits intoNVIDIA:mainfrom
gonidelis:seg_sort_pairs_env
Open

Add stable env DeviceSegmentedSort::Pairs 1/2#8003
gonidelis wants to merge 3 commits intoNVIDIA:mainfrom
gonidelis:seg_sort_pairs_env

Conversation

@gonidelis
Copy link
Copy Markdown
Member

fixes #7551

Follows exactly same logic as #8002

Let's merge it after this one ^^^

@gonidelis gonidelis requested a review from a team as a code owner March 12, 2026 03:58
@gonidelis gonidelis requested a review from pauleonix March 12, 2026 03:58
@github-project-automation github-project-automation bot moved this to Todo in CCCL Mar 12, 2026
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Mar 12, 2026
@gonidelis gonidelis changed the title Add env DeviceSegmentedSort::Pairs and friends Add env DeviceSegmentedSort::Pairs and friends Mar 12, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gonidelis gonidelis enabled auto-merge (squash) March 25, 2026 11:28
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: can we add one representative MR/temp-storage env test here too? At the moment this only checks stream propagation, but these APIs also go through dispatch_with_env, so the memory-resource path is currently untested.

Copy link
Copy Markdown
Member Author

@gonidelis gonidelis Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NaderAlAwar isn't the mr tested by default in lid_2 here?

auto mr = device_memory_resource{{}, stream, &bytes_allocated, &bytes_deallocated};
auto mr_env = cuda::std::execution::prop{cuda::mr::__get_memory_resource_t{}, mr};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That MR coverage exists for the DECLARE_LAUNCH_WRAPPER / TEST_LAUNCH path, but this file explicitly does not use that path, so it doesn’t apply here. This means that there is no lid_2 variant here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wait, I was wrong, I saw an older version of the PR, we do have DECLARE_LAUNCH_WRAPPER here. I still think we should not use lid_2 for similar reasons to here #8286 (comment)

@gonidelis gonidelis force-pushed the seg_sort_pairs_env branch from 06fd843 to 3beffdc Compare April 3, 2026 10:58
@gonidelis gonidelis changed the title Add env DeviceSegmentedSort::Pairs and friends Add stable env DeviceSegmentedSort::Pairs Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

🥳 CI Workflow Results

🟩 Finished in 2h 08m: Pass: 100%/269 | Total: 6d 11h | Max: 2h 08m | Hits: 78%/177097

See results here.

@gonidelis gonidelis changed the title Add stable env DeviceSegmentedSort::Pairs Add stable env DeviceSegmentedSort::Pairs 1/2 Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Add env-based API for cub::DeviceSegmentedSort

2 participants