Skip to content

Add nonstable env DeviceSegmentedSort::Pairs 2/2#8286

Open
gonidelis wants to merge 3 commits intoNVIDIA:mainfrom
gonidelis:seg_sort_pairs_env_nonstable
Open

Add nonstable env DeviceSegmentedSort::Pairs 2/2#8286
gonidelis wants to merge 3 commits intoNVIDIA:mainfrom
gonidelis:seg_sort_pairs_env_nonstable

Conversation

@gonidelis
Copy link
Copy Markdown
Member

Split 2/2 from from #8003 for easier review

@gonidelis gonidelis requested a review from a team as a code owner April 3, 2026 10:47
@github-project-automation github-project-automation bot moved this to Todo in CCCL Apr 3, 2026
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Apr 3, 2026
@gonidelis gonidelis changed the title Add nonstable env DeviceSegmentedSort::Pairs Add nonstable env DeviceSegmentedSort::Pairs Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

🥳 CI Workflow Results

🟩 Finished in 1h 33m: Pass: 100%/249 | Total: 3d 12h | Max: 1h 14m | Hits: 95%/160650

See results here.

DECLARE_LAUNCH_WRAPPER(cub::DeviceSegmentedSort::SortPairs, sort_pairs);
DECLARE_LAUNCH_WRAPPER(cub::DeviceSegmentedSort::SortPairsDescending, sort_pairs_descending);

// %PARAM% TEST_LAUNCH lid 0:1:2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: we should keep this at lid 0:1 for now. The current lid_2 coverage here only uses 2 segments, so it stays below partitioning_threshold and exercises the fallback path which is graph capturable. DeviceSegmentedSort still switches to a partitioning path for larger segment counts, and that path still does a host MemcpyAsync followed by SyncStream(stream), so this does not yet show general graph-capture support. The existing segmented sort tests in cub/test/catch2_test_device_segmented_sort_pairs.cu:10 and cub/test/catch2_test_device_segmented_sort_keys.cu:17 still keep lid_2 disabled for that reason, so this file should stay consistent unless we also prove the partitioning path is capture-safe.

@gonidelis gonidelis changed the title Add nonstable env DeviceSegmentedSort::Pairs Add nonstable env DeviceSegmentedSort::Pairs 2/2 Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants