fix(unit-tests): Prevent relative imports in tests#91
Merged
janickm merged 1 commit intoNVIDIA:mainfrom May 6, 2026
Merged
Conversation
Previously ncore/data/__init__.py was deleted after test execution due to bazel overwriting the package init file - disallow this in test targets and fix all relative imports to be absolute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ncore/data/init.py was deleted after test execution due to bazel overwriting the package init file - disallow this in test targets and fix all relative imports to be absolute.
This pull request primarily updates import statements in various test files to use absolute imports instead of relative imports, improving code clarity and maintainability. Additionally, a minor Bazel configuration change is included.
Test Import Refactoring:
ncore/impl/dataand subdirectories to use absolute imports for modules underncore.impl.dataandncore.impl.data.v4, replacing relative imports. This change helps avoid import errors and improves test robustness and readability. [1] [2] [3] [4] [5]