Skip to content

fix(unit-tests): Prevent relative imports in tests #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janickm merged 1 commit into from
May 6, 2026
Merged

fix(unit-tests): Prevent relative imports in tests #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bazel/pytest/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def pytest_test(name, srcs, python_versions = ["3.11", "3.8"], deps = [], args =
"--capture=no",
] + args + ["$(location :%s)" % x for x in srcs],
srcs_version = "PY3",
legacy_create_init = 0,
deps = deps + [
requirement("pytest"),
],
Expand Down
2 changes: 1 addition & 1 deletion ncore/impl/data/stores_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import parameterized
import zarr

from .stores import IndexedTarStore, consolidate_compressed_metadata, open_compressed_consolidated
from ncore.impl.data.stores import IndexedTarStore, consolidate_compressed_metadata, open_compressed_consolidated


COMPRESSED_CONSOLIDATED_VALUES = [False, True]
Expand Down
3 changes: 1 addition & 2 deletions ncore/impl/data/types_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
import numpy.testing as npt

from ncore.impl.common.transformations import PoseGraphInterpolator

from .types import PointCloud
from ncore.impl.data.types import PointCloud


class TestPointCloud(unittest.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion ncore/impl/data/util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import unittest

from .util import closest_index_sorted
from ncore.impl.data.util import closest_index_sorted


class TestClosestIndexSorted(unittest.TestCase):
Expand Down
6 changes: 2 additions & 4 deletions ncore/impl/data/v4/compat_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@

from ncore.impl.common.transformations import HalfClosedInterval
from ncore.impl.common.util import unpack_optional
from ncore.impl.data.compat import RayBundleSensorPointCloudsSourceAdapter
from ncore.impl.data.types import PointCloud, RowOffsetStructuredSpinningLidarModelParameters

from .compat import SequenceLoaderV4
from .components import (
from ncore.impl.data.v4.compat import SequenceLoaderV4
from ncore.impl.data.v4.components import (
IntrinsicsComponent,
LidarSensorComponent,
PointCloudsComponent,
Expand Down
3 changes: 1 addition & 2 deletions ncore/impl/data/v4/components_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
RowOffsetStructuredSpinningLidarModelParameters,
ShutterType,
)

from .components import (
from ncore.impl.data.v4.components import (
CameraSensorComponent,
ComponentReader,
ComponentWriter,
Expand Down
Loading