Update license expiry calculation to ensure integer return type, now I get a float with -20.91572169669#299
Open
groax wants to merge 1 commit intoNativePHP:mainfrom
Open
Conversation
…I get a float with -20.91572169669
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the number of days until a license expires is calculated across several Blade view files. The calculation now consistently uses
now()->diffInDays($license->expires_at, false)and explicitly casts the result to an integer. This ensures that the difference is calculated with the correct sign (positive or negative), which is important for determining license status and renewal needs.License expiry calculation updates:
$daysUntilExpiryinresources/views/customer/licenses/index.blade.phpto use(int) now()->diffInDays($license->expires_at, false)for accurate signed day differences.resources/views/customer/licenses/list.blade.php, ensuring consistency in license expiry calculations.resources/views/customer/licenses/show.blade.phpto use the new expiry calculation method.resources/views/livewire/customer/licenses.blade.phpfor Livewire components.resources/views/livewire/customer/licenses/show.blade.phpto use the new calculation for renewal logic.